test: close plugin scratch leaks - #2033
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Three plugin test surfaces created temporary directories without durable test-owned cleanup. The runtime incarnation cases also require lifecycle teardown before filesystem removal so cleanup cannot race pending disposers or HostApi operations.
What changed
Risk
Test-only lifecycle cleanup. Production runtime behavior is unchanged.
Validation
bun run test:vitest -- src/plugins/__tests__/plugin-app-visibility-guard.test.ts src/plugins/runtime/__tests__/runtime-state-incarnation.test.ts src/plugins/whitelist/__tests__/secret-gate.test.ts— 3 files, 53 tests passedbun run typecheckgit diff --checkrmSync; no recent matching temporary directories remained after the focused run