Suporte para identificar moeda automaticamente por código/símbolo #82 #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theuves
added
the
new features
… and add test for invalid mode
Ensures decimal parts are only included when non-zero and prevents unnecessary decimal representation
Removed trailing whitespaces and updated TypeScript error handling annotations across multiple test and utility files
- Refactored currency detection tests to use a more structured approach with test cases - Added test helpers for generating formatted amounts with currency codes and symbols - Simplified test cases for currency detection in `detectCurrency()` and `extenso()` - Introduced `currencyTestCases` and `invalidCurrencyTestCases` for more comprehensive testing - Created utility functions `getFormattedAmount()` and `getFormattedAmountWithSymbol()`
…t files" This reverts commit 95bc0a3.
This reverts commit ee14be7.
…d core functions" This reverts commit 942e584.
|
theuves
commented
Mar 9, 2025
There was a problem hiding this comment.
- Em
extenso(): should handle currency codes in different positionsdeveria retornar erro pois em1234.56 EUR 789o789não faz parte do número e em1234.56 789 USDo789também não.- O mesmo ocorre em
extenso(): should handle currency symbols in different positions.
- O mesmo ocorre em
- Em
extenso(): should handle multiple currency indicatorsdeveria retornar erro também; não deveria ser possível passar múltiplas moedas ao mesmo tempo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descrição
Esta PR implementa a funcionalidade de detecção automática de moedas através de códigos (ex: BRL, USD) ou símbolos monetários (ex: R$, $), conforme solicitado na issue #82.
Principais alterações:
Testes
Closes #82