Conversation
Blodir
requested changes
Jan 13, 2026
| queryParams['personToken'] = personToken; | ||
| } | ||
| const params = new HttpParams({fromObject: queryParams}); | ||
| return this.httpClient.get<GeoConversionStatusApiResponse>('/api/geo-convert/status/' + conversionId, {params}); |
Contributor
There was a problem hiding this comment.
could this be converted to use laji-api-client-b at the same time?
Contributor
Author
There was a problem hiding this comment.
Geoconvert api swagger is not correct at the moment so the typings are wrong, I would wait for it to get fixed first. It might not make it to this release if the release is going to be soon
Blodir
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://23000.viranomaiset-dev.laji.fi/
Can be tested by selecting a file download and downloading it in a gis format here https://23000.viranomaiset-dev.laji.fi/en/usage/my-downloads (if you don't have any file downloads you can make one here https://23000.viranomaiset-dev.laji.fi/en/observation).
The new geoconvert api has some changes compared to the old one, for example the person token needs to be included in all the requests and the format query parameter is not used.