Archipelago bird census named place selection [Closes #433]#885
Merged
Blodir merged 16 commits intodevelopmentfrom Jan 14, 2026
Merged
Archipelago bird census named place selection [Closes #433]#885Blodir merged 16 commits intodevelopmentfrom
Blodir merged 16 commits intodevelopmentfrom
Conversation
olzraiti
requested changes
Jan 13, 2026
Contributor
olzraiti
left a comment
olzraiti
left a comment
There was a problem hiding this comment.
One minor whining, otherwise looks good!
Comment on lines
248
to
252
| map(visibleValue => { | ||
| if (visibleValue && visibleValue.length > 0) { | ||
| row[path] = visibleValue; | ||
| } | ||
| }) |
Contributor
There was a problem hiding this comment.
Using map is misleading here. tap would be better since this is a side-effect, not a mapping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
luomus/meta#433
https://433.dev.laji.fi/project/MHL.1166/form/places
Adds new query params
filterByandtabto /form/places.In np-list component, visible values are used in initData to fix filtering to use enum values instead of enum keys.
datatable.component required changes to avoid scrolling before it is visible. The component also emits filteredIDs based on filtered rows.
Filter was previously only applied to the list tab, but now places are also filtered on the map tab. This includes transforming between
fullIdxandfilteredIdxin np-map.component, as the map uses index to refer to the active place and the map indexing changes when a filter changes the number of the shown places.