Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New build system
https://angular.dev/tools/cli/build-system-migration
import * as moment from 'moment';is no longer allowed, use:import moment from 'moment';Modules
I kept ngModules, they are still fully supported, but there's a big move away from modules entirely... Every component is now "standalone" by default, so a migration added "standalone: false" to their component declaration.
Dependencies
NgxWebstorageModuleis removed. It's provided through theprovideNgxWebstoragefunction insteadngx-webstoragev20.19.6, but it will still have to be updated individually in some CI scriptsRxjs 7
Rxjs version bumped and there were various changes. Including:
merge->mergeWith,concat->concatWithetc.rxjs/operatorsare now imported from rootrxjsNew template syntax
*ngFor,*ngIfetc. is all deprecated and will be removed in the next version (22). So I figured we might as well run the migrations now, since everything needs to be tested anyways. Here's a link: https://angular.dev/guide/templates/control-flow. I had to make a few changes where the migration failed. In those cases it looked like an obvious bug, and it's pretty surprising the code was compiling previously. Also post migration I noticed a couple of very weird results: it had inlined a fewng-templates. I didn't go through every change, so there will probably be some oddities that I didn't notice.