Conversation
Blodir
requested changes
Jan 9, 2026
Contributor
Blodir
left a comment
Blodir
left a comment
There was a problem hiding this comment.
Add instructions for token acquisition in readme
Contributor
Author
|
Updated readme |
Blodir
requested changes
Jan 14, 2026
README.md
Outdated
| ACCESS_TOKEN=<YOUR ACCESS TOKEN> | ||
| ``` | ||
|
|
||
| The access token needs to be connected to laji.fi's "system id". Ask one from your colleagues. |
Contributor
There was a problem hiding this comment.
I know in practice there's nobody outside of luomus working on this, but it feels a bit weird to instruct "ask from your colleagues" in a publicly available repo... What are your thoughts? Also btw, can't you just use your personal access token from the api-user endpoint https://apitest.laji.fi/openapi#/API%20user?
Blodir
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently access token is in our git repo (config.json). This PR removes the file and pulls ACCESS_TOKEN from the environment variables, which can be configured with
.envfor example.After merging developers should be notified to update their .env file