Skip to content

Fixed incorrect argument: changed dims to dim#3

Open
framist wants to merge 1 commit intoluodhhh:mainfrom
framist:fix-torch-cat-keyword-dims-problem
Open

Fixed incorrect argument: changed dims to dim#3
framist wants to merge 1 commit intoluodhhh:mainfrom
framist:fix-torch-cat-keyword-dims-problem

Conversation

@framist
Copy link

@framist framist commented Apr 2, 2024

I'd like to express my gratitude to the author for making your invaluable work open-source.

But when employing structure reparameterization on ModernTCN, the following error arises:

TypeError: cat() received an invalid combination of arguments - got (list, dims=int), but expected one of:
* (tuple of Tensors tensors, int dim, *, Tensor out)
* (tuple of Tensors tensors, name dim, *, Tensor out)

The bug is located in the PaddingTwoEdge1d method of the ReparamLargeKernelConv class. However, it erroneously employs the argument name dims instead of dim when invoking torch.cat, leading to this TypeError.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant