Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split core codes into detailed steps(parser, constructor, generator) #229

Merged
merged 1 commit into from
Feb 14, 2018

Conversation

romandev
Copy link
Member

@romandev romandev commented Jan 11, 2018

This change splits core codes into detailed steps in high-level.

  • parser: The parser module is responsible for webidl parsing using
    the webidl2 parser internally. In this step, should create a unique
    type map(key: definition type name, value: AST) as an output.
  • constructor: The constructor module is responsible for constructing
    definition object to generate binding code in generate module.
  • generator: The generator module is responsible for generating actual
    native binding codes.

After this patch, we will be able to use it as follows:

const typeMap: types.IDLTypeMap = await parser.parse(idlFilePaths);
const definitions: types.IRDefinition[] =
    await constructor.construct(typeMap);
await generator.build(definitions);

ISSUE=#207

This change splits core codes into detailed steps in high-level.
  - parser: The parser module is responsible for webidl parsing using
    the webidl2 parser internally. In this step, should create a unique
    type map(key: definition type name, value: AST) as an output.
  - constructor: The constructor module is responsible for constructing
    definition object to generate binding code in generate module.
  - generator: The generator module is responsible for generating actual
    native binding codes.

ISSUE=#207
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant