Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor generator codes #207

Open
1 of 3 tasks
romandev opened this issue Nov 25, 2017 · 0 comments
Open
1 of 3 tasks

Refactor generator codes #207

romandev opened this issue Nov 25, 2017 · 0 comments

Comments

@romandev
Copy link
Member

I'm submitting a ...

  • bug report
  • feature request
  • support request

General infomration

Description

As code complexity increases in the current implementation, readability and test coverage has been poor. So, we need to refactor the WebIDL generator.
romandev added a commit that referenced this issue Nov 25, 2017
@romandev
Implement skeleton codes for a new version of WebIDL compiler
3f92783 
This is a new initial implementation of WebIDL compiler. It has the
following differences compared to the existing one.
  - It is built by `gulp` instead of `gyp`
  - No longer build `generator` and `webidl` separately

ISSUE=#207
@romandev romandev mentioned this issue Nov 25, 2017
Merged
romandev added a commit that referenced this issue Nov 25, 2017
@romandev
Implement skeleton codes for a new version of WebIDL compiler
456f242 
This is a new initial implementation of WebIDL compiler. It has the
following differences compared to the existing one.
  - It is built by `gulp` instead of `gyp`
  - No longer build `generator` and `webidl` separately

ISSUE=#207
romandev added a commit that referenced this issue Nov 25, 2017
@romandev
Implement skeleton codes for a new version of WebIDL compiler
0cc7da7 
This is a new initial implementation of WebIDL compiler. It has the
following differences compared to the existing one.
  - It is built by `gulp` instead of `gyp`
  - No longer build `generator` and `webidl` separately

ISSUE=#207
romandev added a commit that referenced this issue Nov 25, 2017
@romandev
Implement skeleton codes for a new version of WebIDL compiler
ce9e690 
This is a new initial implementation of WebIDL compiler. It has the
following differences compared to the existing one.
  - It is built by `gulp` instead of `gyp`
  - No longer build `generator` and `webidl` separately

ISSUE=#207
romandev added a commit that referenced this issue Nov 25, 2017
@romandev
Implement skeleton codes for a new version of WebIDL compiler
eb713c7 
This is a new initial implementation of WebIDL compiler. It has the
following differences compared to the existing one.
  - It is built by `gulp` instead of `gyp`
  - No longer build `generator` and `webidl` separately

ISSUE=#207
romandev added a commit that referenced this issue Nov 25, 2017
@romandev
Implement skeleton codes for a new version of WebIDL compiler
25fb49b 
This is a new initial implementation of WebIDL compiler. It has the
following differences compared to the existing one.
  - It is built by `gulp` instead of `gyp`
  - No longer build `generator` and `webidl` separately

ISSUE=#207
romandev added a commit that referenced this issue Nov 25, 2017
@romandev
Implement skeleton codes for a new version of WebIDL compiler
494c5b0 
This is a new initial implementation of WebIDL compiler. It has the
following differences compared to the existing one.
  - It is built by `gulp` instead of `gyp`
  - No longer build `generator` and `webidl` separately

ISSUE=#207
romandev added a commit that referenced this issue Nov 25, 2017
@romandev
Implement skeleton codes for a new version of WebIDL compiler (#208)
e848669 
This is a new initial implementation of WebIDL compiler. It has the
following differences compared to the existing one.
  - It is built by `gulp` instead of `gyp`
  - No longer build `generator` and `webidl` separately

ISSUE=#207
romandev added a commit that referenced this issue Nov 25, 2017
@romandev
Initial implementation of a new parser
f484a5c 
This patch includes the following things:
  - Implement reading WebIDL files as IDL fragments in parallel.
  - Introduce a new parser to process individual IDL fragment.
    In this patch, it just creates AST(Abstract Syntax Tree) for now
    by using WebIDL2 parser.
  - Add `base/` and `new_parsaer/` to lint target list.

ISSUE=#207
@romandev romandev mentioned this issue Nov 25, 2017
Merged
romandev added a commit that referenced this issue Nov 25, 2017
@romandev
Initial implementation of a new parser
d5ccc16 
This patch includes the following things:
  - Implement reading WebIDL files as IDL fragments in parallel.
  - Introduce a new parser to process individual IDL fragment.
    In this patch, it just creates AST(Abstract Syntax Tree) for now
    by using WebIDL2 parser.
  - Add `base/` and `new_parsaer/` to lint target list.

ISSUE=#207
romandev added a commit that referenced this issue Nov 26, 2017
@romandev
Initial implementation of a new parser (#209)
9c747a9 
This patch includes the following things:
  - Implement reading WebIDL files as IDL fragments in parallel.
  - Introduce a new parser to process individual IDL fragment.
    In this patch, it just creates AST(Abstract Syntax Tree) for now
    by using WebIDL2 parser.
  - Add `base/` and `new_parsaer/` to lint target list.

ISSUE=#207
romandev added a commit that referenced this issue Dec 20, 2017
@romandev
Add DefinitionInfo and DefinitionInfoMap
990159e 
The `DefinitionInfoMap` is a maplike data structure that manages
`DefinitionInfo` by IDL definition type name. It is exposed to global
scope. It will be used for constructing IR(Intermediate Result) later.

ISSUE=#207
@romandev romandev mentioned this issue Dec 20, 2017
Merged
romandev added a commit that referenced this issue Dec 20, 2017
@romandev
Add DefinitionInfo and DefinitionInfoMap
f050b5b 
The `DefinitionInfoMap` is a maplike data structure that manages
`DefinitionInfo` by IDL definition type name. It is exposed to global
scope. It will be used for constructing IR(Intermediate Result) later.

ISSUE=#207
romandev added a commit that referenced this issue Dec 20, 2017
@romandev
Add DefinitionInfo and DefinitionInfoMap
0d4f795 
The `DefinitionInfoMap` is a maplike data structure that manages
`DefinitionInfo` by IDL definition type name. It is exposed to global
scope. It will be used for constructing IR(Intermediate Result) later.

ISSUE=#207
romandev added a commit that referenced this issue Dec 20, 2017
@romandev
Add DefinitionInfo and DefinitionInfoMap
e6788f2 
The `DefinitionInfoMap` is a maplike data structure that manages
`DefinitionInfo` by IDL definition type name. It is exposed to global
scope. It will be used for constructing IR(Intermediate Result) later.

ISSUE=#207
romandev added a commit that referenced this issue Dec 20, 2017
@romandev
Add DefinitionInfo and DefinitionInfoMap (#221)
122c7ca 
The `DefinitionInfoMap` is a maplike data structure that manages
`DefinitionInfo` by IDL definition type name. It is exposed to global
scope. It will be used for constructing IR(Intermediate Result) later.

ISSUE=#207
romandev added a commit that referenced this issue Dec 20, 2017
@romandev
Add a logic to process interface and partial interface
aa3cab4 
After this patch, `DefinitionInfoMap` can process `interface` and
`partial interface`. Other definitions will be ignored for now.

ISSUE=#207
romandev added a commit that referenced this issue Dec 20, 2017
@romandev
Add a logic to process interface and partial interface
4bef16c 
After this patch, `DefinitionInfoMap` can process `interface` and
`partial interface`. Other definitions will be ignored for now.

ISSUE=#207
@romandev romandev mentioned this issue Dec 20, 2017
Merged
romandev added a commit that referenced this issue Dec 20, 2017
@romandev
Add a logic to process interface and partial interface
de0b541 
After this patch, `DefinitionInfoMap` can process `interface` and
`partial interface`. Other definitions will be ignored for now.

ISSUE=#207
romandev added a commit that referenced this issue Dec 20, 2017
@romandev
Add a logic to process interface and partial interface (#222)
a74fce9 
After this patch, `DefinitionInfoMap` can process `interface` and
`partial interface`. Other definitions will be ignored for now.

ISSUE=#207
romandev added a commit that referenced this issue Dec 27, 2017
@romandev
Add a logic to process dictionary and partial dictionary (#222)
a7189d1 
After this patch, `DefinitionInfoMap` can process `dictionary` and
`partial dictionary`. Other definitions will be ignored for now.

ISSUE=#207
@romandev romandev mentioned this issue Dec 27, 2017
Merged
romandev added a commit that referenced this issue Dec 27, 2017
@romandev
Add a logic to process dictionary and partial dictionary (#222) (#…
1920c26 
…223)

After this patch, `DefinitionInfoMap` can process `dictionary` and
`partial dictionary`. Other definitions will be ignored for now.

ISSUE=#207
romandev added a commit that referenced this issue Dec 27, 2017
@romandev
Add a logic to process enum
8f89379 
After this patch, `DefinitionInfoMap` can process `enum`. Other
definitions will be ignored for now.

ISSUE=#207
@romandev romandev mentioned this issue Dec 27, 2017
Merged
romandev added a commit that referenced this issue Dec 27, 2017
@romandev
Add a logic to process enum (#224)
70ded6c 
After this patch, `DefinitionInfoMap` can process `enum`. Other
definitions will be ignored for now.

ISSUE=#207
romandev added a commit that referenced this issue Jan 4, 2018
@romandev
Migrate generator/new_parser/ to core/parser/
c5258ac 
This change includes the following things:
  - Rename definition_info_map, definition_info with idl_type_map,
    idl_types
  - Sort IDL types matching with upstream (WebIDL2 parser) and add
    related links
  - Move generator/new_parser/ to core/parser/

ISSUE=#207
@romandev romandev mentioned this issue Jan 4, 2018
Merged
romandev added a commit that referenced this issue Jan 4, 2018
@romandev
Migrate generator/new_parser/ to core/parser/ (#228)
1352e61 
This change includes the following things:
  - Rename definition_info_map, definition_info with idl_type_map,
    idl_types
  - Sort IDL types matching with upstream (WebIDL2 parser) and add
    related links
  - Move generator/new_parser/ to core/parser/

ISSUE=#207
romandev added a commit that referenced this issue Jan 11, 2018
@romandev
Split core codes into detailed steps(parser, constructor, generator)
21edc13 
This change splits core codes into detailed steps in high-level.
  - parser: The parser module is responsible for webidl parsing using
    the webidl2 parser internally. In this step, should create a unique
    type map(key: definition type name, value: AST) as an output.
  - constructor: The constructor module is responsible for constructing
    definition object to generate binding code in generate module.
  - generator: The generator module is responsible for generating actual
    native binding codes.

ISSUE=#207
@romandev romandev mentioned this issue Jan 11, 2018
Merged
romandev added a commit that referenced this issue Jan 18, 2018
@romandev
Split core codes into detailed steps(parser, constructor, generator)
b4ecbbb 
This change splits core codes into detailed steps in high-level.
  - parser: The parser module is responsible for webidl parsing using
    the webidl2 parser internally. In this step, should create a unique
    type map(key: definition type name, value: AST) as an output.
  - constructor: The constructor module is responsible for constructing
    definition object to generate binding code in generate module.
  - generator: The generator module is responsible for generating actual
    native binding codes.

ISSUE=#207
romandev added a commit that referenced this issue Feb 14, 2018
@romandev
Split core codes into detailed steps(parser, constructor, generator)
c98ec22 
This change splits core codes into detailed steps in high-level.
  - parser: The parser module is responsible for webidl parsing using
    the webidl2 parser internally. In this step, should create a unique
    type map(key: definition type name, value: AST) as an output.
  - constructor: The constructor module is responsible for constructing
    definition object to generate binding code in generate module.
  - generator: The generator module is responsible for generating actual
    native binding codes.

ISSUE=#207
romandev added a commit that referenced this issue Feb 14, 2018
@romandev
Split core codes into detailed steps(parser, constructor, generator) (#…
3f7af6b 
…229)

This change splits core codes into detailed steps in high-level.
  - parser: The parser module is responsible for webidl parsing using
    the webidl2 parser internally. In this step, should create a unique
    type map(key: definition type name, value: AST) as an output.
  - constructor: The constructor module is responsible for constructing
    definition object to generate binding code in generate module.
  - generator: The generator module is responsible for generating actual
    native binding codes.

ISSUE=#207
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@romandev