Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create module for network-related objects #241

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

notjuanortiz
Copy link
Contributor

@notjuanortiz notjuanortiz commented Jan 18, 2021

Proposed changes

This change is the beginning of the migration of network-related objects into a separate gradle module which should result in faster build times. Contributes to #180.

Pull Request type

What types of changes does your code introduce to Luna?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Unit tests pass locally, after applying my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation
  • Any dependent changes have been merged and published in downstream modules

Further comments

This enables the deletion of the NetworkUtils class since it's not in use by any other objects.
….net)

This also reverts the updated network package name to avoid a huge commit of import changes
@notjuanortiz notjuanortiz changed the title Move abstract Client to separate module Move abstract Client to separate module (network) Jan 18, 2021
@notjuanortiz notjuanortiz changed the title Move abstract Client to separate module (network) Create module for network-related objects Feb 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant