[k8s_0.29] Update k8s.io API to version 0.29 #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
not ready for review yet, work in progress |
Author
|
It's ready for review now |
Author
|
@luksa, it would be great if you could review and approve, so that other people can take use of this PR, thanks! |
rtkypoeluev
commented
Jan 4, 2024
| flag.StringVar(&config.LeaderElection.ResourceLock, "leader-elect-resource-lock", resourcelock.LeasesResourceLock, ""+ | ||
| "The type of resource object that is used for locking during "+ | ||
| "leader election. Supported options are `configmaps` (default) and `endpoints`.") | ||
| "leader election. Supported option is `leases`.") |
Author
There was a problem hiding this comment.
ConfigMaps was replaced by Leases
rtkypoeluev
commented
Jan 4, 2024
| if config.localOnly { | ||
| if config.namespace == "" { | ||
| bytes, err := ioutil.ReadFile("/var/run/secrets/kubernetes.io/serviceaccount/namespace") | ||
| bytes, err := os.ReadFile("/var/run/secrets/kubernetes.io/serviceaccount/namespace") |
Author
There was a problem hiding this comment.
ioutil.ReadFile was replaced with os.ReadFile
rtkypoeluev
commented
Jan 4, 2024
| "os" | ||
|
|
||
| "statefulset-scaledown-controller/pkg/controller" | ||
| "statefulset-scaledown-controller/pkg/signals" |
Author
There was a problem hiding this comment.
using local controller/signals packages instead of github.com/jboss-openshift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the statefulset scaledown controller code to use newer k8s.io API, version 0.29
Changes:
pkg/controllerandpkg/signals(instead ofgithub.com/jboss-openshift/statefulset-scaledown-controller)Testing:
make buildmake imagego build ./...go test ./...