Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another Round Of Link Cleaning (As Best as Possible) #910

Merged
merged 4 commits into from
Nov 27, 2024

Conversation

sharktrexer
Copy link
Contributor

@sharktrexer sharktrexer commented Nov 26, 2024

Regarding #902

@RichardLitt I got a decent chunk of redirects updated and some sour links removed.

There is still a little awesome_bot picks up but I am running into some weird behaviors. For example, https://www.toptal.com/freelance/how-to-work-remotely-and-still-be-the-best redirects to https://www.toptal.com/developers/blog but the bot doesn't pick that up, and the link doesn't redirect if you copy and paste the url directly into the search bar, at least for me.

Anyway I think this is a decent clean up, but again awesome_bot is still a bit angry. Some of the links that can be updated give me back a 403 when I use my own link cleaner, so, I am assuming from my limited knowledge, that some links might need a simulated browser for checking cause some urls really don't like getting requests from "bots".

I also think the awesome_bot workflow should be updated to allow 403 status codes since despite the bot not having authorized access to a url, accessing it with a proper browser shows those urls work fine.

Lemme know if there is anything else I can do to help!

Log of Changes:

Line 48, Status 301 | http://thenextweb.com/news/tools-remote-teams > https://thenextweb.com/news/tools-remote-teams | Updated to most current redirect
Line 54, Status 301 | https://blog.digitalocean.com/currents-july2019/ > https://www.digitalocean.com/blog/currents-july2019/ > https://www.digitalocean.com/blog/currents-july2019 | Updated to most current redirect
Line 89, Status 301 | https://www.groovehq.com/blog/being-a-remote-team > https://blog.groovehq.com/being-a-remote-team | Updated to most current redirect
Line 97, Status 301 | https://m.signalvnoise.com/why-i-work-remotely-hint-it-has-nothing-to-do-with-productivity/ > https://signalvnoise.com/why-i-work-remotely-hint-it-has-nothing-to-do-with-productivity/ > https://signalvnoise.com/svn3/why-i-work-remotely-hint-it-has-nothing-to-do-with-productivity/ | Updated to most current redirect
Line 101, Status 302 | https://stackoverflow.blog/2013/02/why-we-still-believe-in-working-remotely/ > https://stackoverflow.blog/2013/02/01/why-we-still-believe-in-working-remotely/ | Updated to most current redirect
Line 103, Status 301 | http://stephyiu.com/2014/12/13/working-remotely-for-extroverts/ > https://stephyiu.com/2014/12/13/working-remotely-for-extroverts/ | Updated to most current redirect
Line 107, Status -1 | https://snir.dev/blog/remote-async-communication/ | HTTPSConnectionPool(host='snir.dev', port=443): Read timed out. (read timeout=15)
Line 154, Status 301 | https://hnhiring.me/ > http://www.hnhiring.me/ > https://www.hnhiring.me/ | Updated to most current redirect
Line 186, Status -1 | https://www.react-jobs.com | CNAME Error
Line 214, Status 301 | http://www.common.com/ > https://www.common.com/ | Updated to most current redirect
Line 218, Status 301 | http://nestcopenhagen.dk/ > http://www.nestcopenhagen.dk > https://www.nestcopenhagen.dk/ | Updated to most current redirect
Line 223, Status 301 | https://talentgarden.org/en/coworking/ > https://talentgarden.com/en/coworking | Updated to most current redirect
Line 257, Status 301 | https://www.mailerlite.com/blog/category/behind-the-scenes > https://www.mailerlite.com | Updated to most current redirect
Line 262, Status -1 | https://www.yonder.io/ | Domain is for sale.
Line 278, Status 301 | https://agentfire.com/about-agentfire/ > https://agentfire.com/ | Updated to most current redirect
Line 282, Status 302 | https://alley.com/jobs/ > https://alley.com/careers/ | Updated to most current redirect
Line 284, Status -1 | http://humihr.ca | HTTPConnectionPool(host='humihr.ca', port=80): Max retries exceeded with url: / (Caused by NameResolutionError("<urllib3.connection.HTTPConnection object at 0x00000161B707FD90>: Failed to resolve 'humihr.ca' ([Errno 11001] getaddrinfo failed)"))
Line 290, Status 301 | https://auth0.com/careers > https://www.okta.com/company/careers/ | Updated to most current redirect
Line 296, Status 301 | https://avantstay.workable.com/ > https://apply.workable.com/avantstay/ | Updated to most current redirect
Line 302, Status 301 | https://www.bebanjo.com/careers/ > https://www.bebanjo.com/company/careers/ > https://www.bebanjo.com/company/careers | Updated to most current redirect   
Line 307, Status 301 | https://www.bookingsync.com/en/careers > https://www.smily.com/company/jobs | Updated to most current redirect
Line 314, Status 302 | https://canonical.com/careers/all-vacancies > https://canonical.com/careers/all | Updated to most current redirect
Line 324, Status 301 | https://consensys.io/careers/ > https://consensys.io/careers | Updated to most current redirect
Line 339, Status 308 | https://doist.com/jobs > https://doist.com/careers | Updated to most current redirect
Line 348, Status 308 | https://www.envato.com/careers > https://www.envato.com/careers/ > https://www.envato.com/about/careers/ | Updated to most current redirect
Line 361, Status 308 | https://gitbook.gitbook.io/join-gitbook/ > https://gitbook.gitbook.io/join-gitbook | Updated to most current redirect
Line 362, Status 301 | https://github.careers > https://www.github.careers/ > https://www.github.careers/careers-home | Updated to most current redirect
Line 368, Status 404 | https://hanzo.co/about-us/careers-uk | Does not exist
Line 370, Status 308 | https://www.hashicorp.com/jobs > https://www.hashicorp.com/careers | Updated to most current redirect
Line 372, Status 301 | https://heap.io/careers/jobs > https://www.heap.io/careers/jobs | Updated to most current redirect
Line 377, Status 301 | https://hotjar.com/careers > https://www.hotjar.com/careers > https://www.hotjar.com/careers/ | Updated to most current redirect
Line 379, Status 301 | http://www.igalia.com/about > https://www.igalia.com/about > https://www.igalia.com/about/ | Updated to most current redirect
Line 382, Status 301 | https://inn.org/jobs/ > https://inn.users.membersuite.com/community/career-center/browse-jobs/allJobs/allCities/allStates | Updated to most current redirect
Line 386, Status 301 | https://imachines.workable.com > https://apply.workable.com/imachines/ | Updated to most current redirect
Line 406, Status 308 | https://madewithlove.com/jobs/ > https://madewithlove.com/careers/ | Updated to most current redirect
Line 411, Status 301 | https://www.mapbox.com/careers/ > https://www.mapbox.com/careers | Updated to most current redirect
Line 414, Status 301 | https://www.merico.dev/ > https://www.devinsight.ai/ | Updated to most current redirect
Line 415, Status 301 | http://www.mixmax.com/ > https://www.mixmax.com/ | Updated to most current redirect
Line 421, Status 302 | https://www.mozilla.org/careers/listings/ > https://www.mozilla.org/en-US/careers/listings/ | Updated to most current redirect
Line 425, Status 301 | https://www.ninjacat.io/company/company > https://www.ninjacat.io/company/about-us | Updated to most current redirect
Line 439, Status 301 | https://pleo.io/careers/ > https://www.pleo.io/careers/ > https://www.pleo.io/careers > https://www.pleo.io/us/careers > https://www.pleo.io/en/careers | Updated to most current redirect
Line 444, Status 301 | http://www.profinda.com/ > https://www.profinda.com/ | Updated to most current redirect
Line 446, Status 301 | https://www.rainforestqa.com/jobs > https://jobs.lever.co/rainforest | Updated to most current redirect
Line 447, Status 301 | http://home.rebelmouse.com/st/blog > https://home.rebelmouse.com/st/blog > https://www.rebelmouse.com/st/blog | Updated to most current redirect
Line 449, Status 301 | https://www.redhat.com/en/jobs/ > https://www.redhat.com/en/jobs | Updated to most current redirect
Line 459, Status 301 | http://search.jobvite.com?invalid=1 > https://search.jobvite.com/?invalid=1 > https://www.jobvite.com/support/job-seeker-support//?invalid=1 > https://www.jobvite.com/support/job-seeker-support/?invalid=1 | Updated to most current redirect
Line 463, Status 301 | https://www.signal.org > https://signal.org/ | Updated to most current redirect
Line 475, Status 308 | https://surevine.com/jobs/ > https://surevine.com/jobs > https://surevine.com/careers | Updated to most current redirect
Line 481, Status 301 | https://www.taxjar.com/life/careers/#open-positions > https://www.taxjar.com | Updated to most current redirect
Line 483, Status 301 | http://www.teamsnap.com/company/careers > https://www.teamsnap.com/company/careers | Updated to most current redirect
Line 485, Status 301 | https://www.teamsnap.com/company/careers | Doppelganger of TeamSnap, Line 483
Line 490, Status 301 | https://www.timedoctor.com/about-us > https://www.timedoctor.com/about | Updated to most current redirect
Line 491, Status 301 | https://toggl.com:443/jobs > https://toggl.com/jobs/ | Updated to most current redirect
Line 520, Status 521 | https://webchat.freenode.net/?channels=#remotes | Server Could Not Handle Request
Line 525, Status 302 | https://dsc.gg/invide > https://r.dsc.gg/invide > https://discord.gg/92q23kCad2 > https://discord.com/invite/92q23kCad2 | Updated to most current redirect 
Line 528, Status 302 | https://www.yonder.io/ | Doppelganger of Yonder Newsletter, Line 262
Line 549, Status 301 | https://signal.org/ | Doppelganger of Signal app, Line 463 (but I kept it since it seemed like it made sense)
Line 551, Status 301 | https://screenhero.com > https://slack.com/features/huddles | Updated to most current redirect
Line 588, Status 301 | https://wise.com/gb/business/international-payroll-via-batch-payments > https://wise.com/gb/business/payouts | Updated to most current redirect
Line 595, Status 301 | https://nomadlist.com > https://nomads.com/ | Updated to most current redirect

@RichardLitt RichardLitt merged commit eecaeee into lukasz-madon:master Nov 27, 2024
1 check failed
@RichardLitt
Copy link
Collaborator

Thank you, this is great. Trusting you on the redirects - excellent write-up.

Not sure that I can update awesome_bot with my current permissions.

@sharktrexer
Copy link
Contributor Author

Not sure if this is the best place to discuss? But I think I can just open a PR that edits the workflow. I would basically just add 403 after the -a where awesome_bot function is called. I am unsure if that requires additional permissions for you to merge, still learning a lot myself.

Thanks for the trust, was fun working on this as you can probably tell 😁

@RichardLitt
Copy link
Collaborator

Shouldn't be impossible for me to merge. Go ahead!

@sharktrexer sharktrexer deleted the update_redirects branch December 5, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants