Skip to content

Add warning messages to UI changes #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aegbert5 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add warning messages to UI changes #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions admin/app/com/lucidchart/piezo/admin/views/job.scala.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,13 +66,23 @@ <h4>Are you sure you want to run this job right now?</h4>
<button type="button" class="btn btn-default" onclick="$('#runConfirm').hide()">Cancel</button>
</div>

<!-- Delete Job Alerts -->
<div id="deleteConfirm" style="display:none;" class="alert alert-warning fade in">
<h4>This will permanently delete the job!</h4>
<button type="button" class="btn btn-danger" onclick="deleteJob()">Delete</button>
<button type="button" class="btn btn-default" onclick="$('#deleteConfirm').hide()">Cancel</button>
</div>
@defining(configuration.getOptional[Boolean]("com.lucidchart.piezo.admin.production").contains(true)) { inProd =>
@defining(configuration.getOptional[String]("com.lucidchart.piezo.admin.confirmDeleteMessage").getOrElse("This will permanently delete the job!")) { confirmDeleteMessage =>
<!-- Delete Job Alerts -->
<div id="deleteConfirm" style="display:none;" class="alert alert-@if(inProd) {danger} else {warning} fade in">
<h4>@(confirmDeleteMessage)</h4>
<button type="button" class="btn btn-danger" onclick="deleteJob()">Delete</button>
<button type="button" class="btn btn-default" onclick="$('#deleteConfirm').hide()">Cancel</button>
</div>
}
@defining(configuration.getOptional[String]("com.lucidchart.piezo.admin.confirmEditMessage").getOrElse("This will modify the job!")) { confirmEditMessage =>
<!-- Edit Job Alerts -->
<div id="editConfirm" style="display:none;" class="alert alert-@if(inProd) {danger} else {warning} fade in">
<h4>@(confirmEditMessage)</h4>
<button type="button" class="btn btn-danger" onclick="editTrigger()">Edit</button>
<button type="button" class="btn btn-default" onclick="$('#editConfirm').hide()">Cancel</button>
</div>
}
<!-- Pause Job Alerts -->
<div id="pauseConfirm" style="display: none;" class="alert alert-@if(inProd) {danger} else {warning} fade in">
<h4>Are you sure you want to pause the job?</h4>
Expand Down
7 changes: 7 additions & 0 deletions admin/app/com/lucidchart/piezo/admin/views/trigger.scala.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,18 @@ <h3 class="pull-left">@currentTrigger.get.getKey.getGroup() &raquo; <span class=
<p id="errorMessage"></p>
</div>

<!-- Delete Trigger Alert -->
<div id="deleteConfirm" style="display:none;" class="alert alert-warning fade in">
<h4>This will permanently delete the trigger!</h4>
<button type="button" class="btn btn-danger" onclick="deleteTrigger()">Delete</button>
<button type="button" class="btn btn-default" onclick="$('#deleteConfirm').hide()">Cancel</button>
</div>
<!-- Modify Trigger Alert -->
<div id="editConfirm" style="display:none;" class="alert alert-warning fade in">
<h4>This will permanently delete the trigger!</h4>
Copy link
Contributor

@tmccombs tmccombs Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This message doesn't look correct. Shouldn't this say something about modifying the trigger?

<button type="button" class="btn btn-danger" onclick="editTrigger()">Edit</button>
<button type="button" class="btn btn-default" onclick="$('#editConfirm').hide()">Cancel</button>
</div>
<script>

function showErrorMessage(message) {
Expand Down
2 changes: 2 additions & 0 deletions admin/conf/application.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ i18n.langs = ["en"]
# evolutionplugin=disabled
com.lucidchart.piezo.heartbeatFile="/tmp/piezo/workerHeartbeatFile"
com.lucidchart.piezo.admin.production=false
com.lucidchart.piezo.admin.confirmDeleteMessage="This will permanently delete the job!"
com.lucidchart.piezo.admin.confirmEditMessage="This will modify the job!"
healthCheck.worker.minutesBetween=5
play.application.loader=com.lucidchart.piezo.admin.PiezoAdminApplicationLoader

Expand Down
Loading