-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add eager inference annotation for polymorphic types #106
Open
Ukendio
wants to merge
29
commits into
luau-lang:master
Choose a base branch
from
Ukendio:add-eager-inference-annotation-for-polymorphic-types
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+72
−0
Open
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
213ec9f
Create monomorphic-type-bindings-for-generics.md
Ukendio cb82f7a
Update monomorphic-type-bindings-for-generics.md
Ukendio bf354a1
Update and rename monomorphic-type-bindings-for-generics.md to eager-…
Ukendio 8f1c0d9
Update "Function-parameter-bindings" alternative
hardlyardi 8a24f5b
Add .md extension
hardlyardi 9df20a0
Update eager-inference-annotations-for-polymorphic-types.md
Ukendio e25643f
change per-function-parameter to per-argument
hardlyardi 1943be7
change "generic" to "polymorphic type" in a few places
hardlyardi 1d36401
Punctuation Fixes
hardlyardi 1c8d217
change "inference behavior" to "instantiation behavior" in alternative
hardlyardi 2ed0187
Update eager-inference-annotations-for-polymorphic-types.md
hardlyardi b7c2800
add line break
hardlyardi b47e000
Update wording in summary
hardlyardi 29384af
add comma
hardlyardi f5c5609
Update eager-inference-annotations-for-polymorphic-types.md
Ukendio b995140
remove redundant "union behavior"
hardlyardi 5308d81
Update eager-inference-annotations-for-polymorphic-types.md
Ukendio c9328c7
Update eager-inference-annotations-for-polymorphic-types.md
Ukendio 27d8c66
changes to alternatives
hardlyardi cbc02bd
general changes + rephrasing
hardlyardi 9fa24be
add single char monospace
hardlyardi 96f8aaa
Update eager-inference-annotations-for-polymorphic-types.md
Ukendio b83c473
small consistency/grammar change
hardlyardi 1fee95b
add return statement
hardlyardi 458dcb6
fix spelling :(
hardlyardi 8bb92ba
Amend per-function-bindings to per-usage-bindings
hardlyardi 7d20d52
separate noinfer alternative for clarity
hardlyardi 2463447
Update eager-inference-annotations-for-polymorphic-types.md
hardlyardi 6264249
Update eager-inference-annotations-for-polymorphic-types.md
Ukendio File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix spelling :(
commit 458dcb645fdf9fb097613105d5f075fb59e31716
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is "Luau's current solver?"
We have two products right now, Luau's Type Solver and Luau's New Type Solver. "type solver" is really a brand name coined by @andyfriesen, not something external folks necessarily recognize. Could also reasonably describe it as Luau's V2 type inference engine or something of that sort, honestly not entirely sure how we want to deal with the language around the two type inference systems in RFCs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. I considered this while editing the motivation paragraph, but was unsure if "type inference engine V2" was even the correct terminology to use. For now I'll switch the terminology there to "Luau's Type Inference Engine V2"?