Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Score calculation and avoid counting 'dismissed'-reviews as comments #97

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

GODrums
Copy link
Contributor

@GODrums GODrums commented Sep 18, 2024

Description

This PR fixes stats for the leaderboard.

  • the score calculation formula was missing a divison by 10
  • dismissed-reviews are no longer counted as comment (commented-state)

The original Python script goes a step further and backtraces dismissed-reviews to their original state. For now I was unable to figure out how to translate this behavior to our API-Wrapper, we might be able to do this in a follow-up.

Screenshots (if applicable)

Checklist

General

  • PR title is clear and descriptive
  • PR description explains the purpose and changes
  • Code follows project coding standards
  • Self-review of the code has been done
  • Changes have been tested locally

Server (if applicable)

  • Code is performant and follows best practices
  • No security vulnerabilities introduced
  • Proper error handling has been implemented
  • Added tests for new functionality

@GODrums GODrums added bug Something isn't working application-server priority:high Crucial tasks needing prompt attention. labels Sep 18, 2024
@GODrums GODrums added this to the Gamification Leaderboard MVP milestone Sep 18, 2024
@GODrums GODrums self-assigned this Sep 18, 2024
@github-actions github-actions bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 18, 2024
Copy link
Collaborator

@FelixTJDietrich FelixTJDietrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FelixTJDietrich FelixTJDietrich merged commit a708853 into develop Sep 18, 2024
7 checks passed
@FelixTJDietrich FelixTJDietrich deleted the fix/leaderboard-review-state-counting branch September 18, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application-server bug Something isn't working priority:high Crucial tasks needing prompt attention. size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants