Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove example code #84

Merged
merged 34 commits into from
Sep 15, 2024
Merged

Remove example code #84

merged 34 commits into from
Sep 15, 2024

Conversation

FelixTJDietrich
Copy link
Collaborator

@FelixTJDietrich FelixTJDietrich commented Sep 14, 2024

Motivation

Code is now unused, we have now existing code which we can

Description

Remove counter and hello components and the server code associated with it.

@github-actions github-actions bot added client application-server size:L This PR changes 100-499 lines, ignoring generated files. labels Sep 14, 2024
@github-actions github-actions bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed autocommit-openapi size:L This PR changes 100-499 lines, ignoring generated files. labels Sep 14, 2024
@GODrums
Copy link
Contributor

GODrums commented Sep 14, 2024

LGTM! Would love it, if you could leave it in until the Leaderboard PR is merged though as I'm using the Hello to test my server right now sometimes 😄

@FelixTJDietrich
Copy link
Collaborator Author

It is stacked on your PR, of course I will merge it afterwards :)

Base automatically changed from feature/leaderboard-page to develop September 15, 2024 00:19
@github-actions github-actions bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Sep 15, 2024
@github-actions github-actions bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Sep 15, 2024
@FelixTJDietrich FelixTJDietrich merged commit 93de045 into develop Sep 15, 2024
5 checks passed
@FelixTJDietrich FelixTJDietrich deleted the chore/cleanup-example-code branch September 15, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application-server client size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants