-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove example code #84
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1intum/Hephaestus into feature/schema-update-reviews
github-actions
bot
added
client
application-server
size:L
This PR changes 100-499 lines, ignoring generated files.
labels
Sep 14, 2024
github-actions
bot
added
size:XL
This PR changes 500-999 lines, ignoring generated files.
and removed
autocommit-openapi
size:L
This PR changes 100-499 lines, ignoring generated files.
labels
Sep 14, 2024
11 tasks
LGTM! Would love it, if you could leave it in until the Leaderboard PR is merged though as I'm using the Hello to test my server right now sometimes 😄 |
It is stacked on your PR, of course I will merge it afterwards :) |
github-actions
bot
added
size:XXL
This PR changes 1000+ lines, ignoring generated files.
and removed
size:XL
This PR changes 500-999 lines, ignoring generated files.
labels
Sep 15, 2024
github-actions
bot
added
size:XL
This PR changes 500-999 lines, ignoring generated files.
and removed
size:XXL
This PR changes 1000+ lines, ignoring generated files.
labels
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Code is now unused, we have now existing code which we can
Description
Remove counter and hello components and the server code associated with it.