Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ApplicationRunner with EventListener to fix startup time #83

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

GODrums
Copy link
Contributor

@GODrums GODrums commented Sep 13, 2024

Motivation

Guarantee the Github sync only runs after the server has started and is available.

Description

Replaces the ApplicationRunner with an EventLister for the ApplicationReadyEvent event.

Checklist

General

  • PR title is clear and descriptive
  • PR description explains the purpose and changes
  • Code follows project coding standards
  • Self-review of the code has been done
  • Changes have been tested locally

Server (if applicable)

  • Code is performant and follows best practices
  • No security vulnerabilities introduced
  • Proper error handling has been implemented
  • Added tests for new functionality
  • Changes have been tested in different environments (if applicable)

@GODrums GODrums added bug Something isn't working application-server labels Sep 13, 2024
@GODrums GODrums added this to the Gamification Leaderboard MVP milestone Sep 13, 2024
@GODrums GODrums self-assigned this Sep 13, 2024
@github-actions github-actions bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 13, 2024
Copy link
Collaborator

@FelixTJDietrich FelixTJDietrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@FelixTJDietrich FelixTJDietrich changed the title application-server: Replace ApplicationRunner with EventListener Replace ApplicationRunner with EventListener to fix startup time Sep 13, 2024
@FelixTJDietrich FelixTJDietrich merged commit 2f28091 into develop Sep 13, 2024
6 checks passed
@FelixTJDietrich FelixTJDietrich deleted the fix/server-startup-runner branch September 13, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application-server bug Something isn't working size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants