Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Server Endpoint for the Leaderboard #80

Merged

Conversation

GODrums
Copy link
Contributor

@GODrums GODrums commented Sep 12, 2024

Motivation

Closes #77.

Description

  • Adds the /leaderboard-endpoint, which provides the required data for the leaderboard calculated on-demand
  • Fixes the LazyInitializationException with dynamic eager fetching following Artemis's DB guidelines
  • Adds an environment variable monitoring.timeframe to control the number of past days to be fetched for PRs and review comments (creation date)
  • Interesting remark: depending on the new timeframe, fetching and hence the server startup can take pretty long. Example for just the Artemis repo: 1 day -> ~20 seconds, 7 days -> ~1 minute

Checklist

General

  • PR title is clear and descriptive
  • PR description explains the purpose and changes
  • Code follows project coding standards
  • Self-review of the code has been done
  • Changes have been tested locally

Server (if applicable)

  • Code is performant and follows best practices
  • No security vulnerabilities introduced
  • Proper error handling has been implemented
  • Added tests for new functionality
  • Changes have been tested in different environments (if applicable)

@GODrums GODrums added this to the Gamification Leaderboard MVP milestone Sep 12, 2024
@GODrums GODrums self-assigned this Sep 12, 2024
@GODrums GODrums linked an issue Sep 12, 2024 that may be closed by this pull request
@github-actions github-actions bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 12, 2024
@github-actions github-actions bot added client size:XL This PR changes 500-999 lines, ignoring generated files. and removed autocommit-openapi size:L This PR changes 100-499 lines, ignoring generated files. labels Sep 12, 2024
Copy link
Collaborator

@FelixTJDietrich FelixTJDietrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks generally good to me :)

@FelixTJDietrich FelixTJDietrich merged commit aa7b783 into develop Sep 13, 2024
3 checks passed
@FelixTJDietrich FelixTJDietrich deleted the 77-create-server-endpoint-for-the-leaderboard branch September 13, 2024 08:08
@GODrums GODrums mentioned this pull request Sep 13, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application-server client enhancement New feature or request feature size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create server endpoint for the leaderboard
2 participants