-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Server Endpoint for the Leaderboard #80
Merged
FelixTJDietrich
merged 9 commits into
develop
from
77-create-server-endpoint-for-the-leaderboard
Sep 13, 2024
Merged
Create Server Endpoint for the Leaderboard #80
FelixTJDietrich
merged 9 commits into
develop
from
77-create-server-endpoint-for-the-leaderboard
Sep 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GODrums
added
enhancement
New feature or request
application-server
feature
autocommit-openapi
labels
Sep 12, 2024
github-actions
bot
added
the
size:L
This PR changes 100-499 lines, ignoring generated files.
label
Sep 12, 2024
github-actions
bot
added
client
size:XL
This PR changes 500-999 lines, ignoring generated files.
and removed
autocommit-openapi
size:L
This PR changes 100-499 lines, ignoring generated files.
labels
Sep 12, 2024
FelixTJDietrich
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks generally good to me :)
FelixTJDietrich
deleted the
77-create-server-endpoint-for-the-leaderboard
branch
September 13, 2024 08:08
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
application-server
client
enhancement
New feature or request
feature
size:XL
This PR changes 500-999 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #77.
Description
/leaderboard
-endpoint, which provides the required data for the leaderboard calculated on-demandLazyInitializationException
with dynamic eager fetching following Artemis's DB guidelinesmonitoring.timeframe
to control the number of past days to be fetched for PRs and review comments (creation date)Checklist
General
Server (if applicable)