Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Reviews to PullRequest entities #76

Merged
merged 27 commits into from
Sep 9, 2024
Merged

Add Reviews to PullRequest entities #76

merged 27 commits into from
Sep 9, 2024

Conversation

GODrums
Copy link
Contributor

@GODrums GODrums commented Sep 4, 2024 •
edited
Loading

Motivation

Adds reviews as part of the Github data collection.

Description

This PR adds reviews of a pull request to their pull request entity. This currently includes code comments, which might be part of a review, but excludes Github issues and their respective comments

Screenshots (if applicable)

Checklist

General

  • PR title is clear and descriptive
  • PR description explains the purpose and changes
  • Code follows project coding standards
  • Self-review of the code has been done
  • Changes have been tested locally
  • Screenshots have been attached (if applicable)
  • Documentation has been updated (if applicable)

Server (if applicable)

  • Code is performant and follows best practices
  • No security vulnerabilities introduced
  • Proper error handling has been implemented
  • Added tests for new functionality
  • Changes have been tested in different environments (if applicable)

@GODrums GODrums added enhancement New feature or request application-server labels Sep 4, 2024
@GODrums GODrums added this to the Gamification Leaderboard MVP milestone Sep 4, 2024
@GODrums GODrums self-assigned this Sep 4, 2024
@github-actions github-actions bot added feature size:L This PR changes 100-499 lines, ignoring generated files. labels Sep 4, 2024
@github-actions github-actions bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Sep 6, 2024
@milesha milesha self-requested a review September 8, 2024 07:47
FelixTJDietrich
FelixTJDietrich requested changes Sep 8, 2024
View reviewed changes
Copy link
Collaborator

@FelixTJDietrich FelixTJDietrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only small change request/questions. Code generally LGTM

...rc/main/java/de/tum/in/www1/hephaestus/codereview/comment/review/ReviewCommentConverter.java Outdated Show resolved Hide resolved
...src/main/java/de/tum/in/www1/hephaestus/codereview/pullrequest/review/PullRequestReview.java Outdated Show resolved Hide resolved
...java/de/tum/in/www1/hephaestus/codereview/pullrequest/review/PullRequestReviewConverter.java Outdated Show resolved Hide resolved
...java/de/tum/in/www1/hephaestus/codereview/pullrequest/review/PullRequestReviewConverter.java Outdated Show resolved Hide resolved
...cation-server/src/main/java/de/tum/in/www1/hephaestus/scheduler/GitHubDataSyncScheduler.java Show resolved Hide resolved
@GODrums GODrums mentioned this pull request Sep 8, 2024
Merged
11 tasks
FelixTJDietrich
FelixTJDietrich previously approved these changes Sep 9, 2024
View reviewed changes
@GODrums GODrums dismissed FelixTJDietrich’s stale review September 9, 2024 08:06

The merge-base changed after approval.

@FelixTJDietrich FelixTJDietrich merged commit 23c3967 into develop Sep 9, 2024
3 checks passed
@FelixTJDietrich FelixTJDietrich deleted the feature/schema-update-reviews branch September 9, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iam-flo iam-flo iam-flo left review comments

@FelixTJDietrich FelixTJDietrich FelixTJDietrich left review comments

@milesha milesha Awaiting requested review from milesha

Assignees

@GODrums GODrums

Labels
application-server client enhancement New feature or request feature size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
Gamification Leaderboard MVP
Development

Successfully merging this pull request may close these issues.
3 participants
@GODrums @FelixTJDietrich @iam-flo