Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subject sanitization and retry to publish on error #66

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

FelixTJDietrich
Copy link
Collaborator

@FelixTJDietrich FelixTJDietrich commented Aug 22, 2024

Motivation

Fixes #64 and fixes #65

Description

  • Add sanitization for the subject to replace . with ~
  • Retry publish to NATS on error

@github-actions github-actions bot added bug Something isn't working webhook-ingest size:M This PR changes 30-99 lines, ignoring generated files. labels Aug 22, 2024
@FelixTJDietrich FelixTJDietrich changed the title add subject sanitization and retry to publish on error Add subject sanitization and retry to publish on error Aug 22, 2024
@FelixTJDietrich FelixTJDietrich merged commit f839d1f into develop Aug 22, 2024
4 checks passed
@FelixTJDietrich FelixTJDietrich deleted the fix/nats-issues branch August 22, 2024 21:39
@FelixTJDietrich FelixTJDietrich added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size:M This PR changes 30-99 lines, ignoring generated files. webhook-ingest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent dots in subject parts Handle NATS Errors
1 participant