-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add first GitHub entities and automatically fetch them for the leaderboard #62
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not look at everything, but some comments also apply to the other files. Let's do this PR right and set the standard for future PRs :) Also as reference.
server/application-server/src/main/java/de/tum/in/www1/hephaestus/codereview/actor/Actor.java
Outdated
Show resolved
Hide resolved
server/application-server/src/main/java/de/tum/in/www1/hephaestus/codereview/actor/Actor.java
Outdated
Show resolved
Hide resolved
server/application-server/src/main/java/de/tum/in/www1/hephaestus/codereview/actor/Actor.java
Outdated
Show resolved
Hide resolved
server/application-server/src/main/java/de/tum/in/www1/hephaestus/codereview/actor/Actor.java
Outdated
Show resolved
Hide resolved
server/application-server/src/main/java/de/tum/in/www1/hephaestus/codereview/actor/Actor.java
Outdated
Show resolved
Hide resolved
server/application-server/src/main/java/de/tum/in/www1/hephaestus/EnvConfig.java
Outdated
Show resolved
Hide resolved
...application-server/src/main/java/de/tum/in/www1/hephaestus/codereview/CodeReviewService.java
Outdated
Show resolved
Hide resolved
...application-server/src/main/java/de/tum/in/www1/hephaestus/codereview/CodeReviewService.java
Outdated
Show resolved
Hide resolved
server/application-server/src/main/java/de/tum/in/www1/hephaestus/Application.java
Outdated
Show resolved
Hide resolved
...application-server/src/main/java/de/tum/in/www1/hephaestus/codereview/CodeReviewService.java
Outdated
Show resolved
Hide resolved
…s1intum/Hephaestus into feature/github-graphql-artemis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more final comments
...ation-server/src/main/java/de/tum/in/www1/hephaestus/codereview/pullrequest/Pullrequest.java
Outdated
Show resolved
Hide resolved
...-server/src/main/java/de/tum/in/www1/hephaestus/ClassImportIntegratorIntegratorProvider.java
Show resolved
Hide resolved
...n-server/src/main/java/de/tum/in/www1/hephaestus/scheduler/DailyGitHubDataSyncScheduler.java
Outdated
Show resolved
Hide resolved
...lication-server/src/main/java/de/tum/in/www1/hephaestus/scheduler/GitHubDataSyncService.java
Outdated
Show resolved
Hide resolved
...plication-server/src/main/java/de/tum/in/www1/hephaestus/errors/EntityNotFoundException.java
Outdated
Show resolved
Hide resolved
...plication-server/src/main/java/de/tum/in/www1/hephaestus/codereview/user/UserController.java
Outdated
Show resolved
Hide resolved
I think the code looks good now, maybe you can take a quick look at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have only a minor comment, the rest looks fine. You still need to make the checks pass.
...server/src/main/java/de/tum/in/www1/hephaestus/codereview/comment/IssueCommentConverter.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM now, thank you!
Motivation
To make our Leaderboard possible, we first have to fetch the required PRs / Comments data from Github's API and store them in the database, as well as make the data available through our own API.
Description
application-local.yml
-support for the Github PATNext up for the leaderboard (in other PRs):
Screenshots (if applicable)
Checklist
General
Server (if applicable)