Update CreateHost variables to accept interface instead of string#17
Open
dakota-marshall wants to merge 2 commits intolrsmith:masterfrom
Open
Update CreateHost variables to accept interface instead of string#17dakota-marshall wants to merge 2 commits intolrsmith:masterfrom
dakota-marshall wants to merge 2 commits intolrsmith:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Closed and reopened this request as I renamed the downstream branch so I can continue working with the
masterbranch name, sorry about thatThe Icinga API documentation mentions that it accepts a dict for the vars attribute of a Host object. The HostAttrs struct also accepts an interface, this changes brings CreateHost to match with map[string]interface{} instead of forcing the limited scope of map[string]string
I updated the tests and ran them locally, and they passed, though admittedly I ran them manually as I am not entirely sure how to use the Makefile.
This is a precursor to attempting to fix the downstream Terraform provider that does not accept anything other than a string: Icinga/terraform-provider-icinga2#88
Let me know if I am missing anything!