Improve github action workflow instructions #1582
Merged
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lowlighter
approved these changes
Dec 18, 2023
|
Thanks for taking the time to update the documentation and the screenshot ! |
n0099
added a commit
to n0099/n0099
that referenced
this pull request
Dec 29, 2023
$ sed -ri 's/runs-on: ubuntu-latest$/\0\n environment:\n name: production/' .github/workflows/* # lowlighter/metrics#1582
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made some changes to github action workflow template in order to make it more understandable and clear for new users.
Before implementing my proposed solution, I noticed that the initial code provided wasn't functioning as expected (you can see more about the issue here). I took the liberty of addressing the issues I identified to ensure a more robust and effective solution.
Please review the changes and feel free to provide any feedback or suggestions !!!