[sw] Add nonstring attribute
#27562
Merged
[sw] Add nonstring attribute
#27562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamaury
reviewed
Jul 7, 2025
pamaury
reviewed
Jul 7, 2025
Adds the `nonstring` attribute through a new `OT_NONSTRING` macro. This is used to prevent warnings when compiling with Clang 21+ and an array is initialized with a string literal but is sized not to include the terminating null. Signed-off-by: Luís Marques <[email protected]>
|
Looks okay, thanks @marnovandermaas found a lot of byte strings which don't explicitly list the array size and might not trigger the warnings. I don't know if we want to do anything about these. They're mostly KMAC tests: |
jwnrt
approved these changes
Jul 7, 2025
pamaury
approved these changes
Jul 7, 2025
There was a problem hiding this comment.
I have a related PR for KMAC here: #27558
That one still needs some fixing because the test was actually wrong in the first place and is now failing. So probably best to get this PR in first and then I can keep working on the KMAC one.
luismarques
added
the
CherryPick:earlgrey_1.0.0
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
nonstringattribute through a newOT_NONSTRINGmacro. This is used to prevent warnings when compiling with Clang 21+ and an array is initialized with a string literal but is sized not to include the terminating null.