Erode / dilate preliminary implementation #4243
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merci beaucoup for the PR Quentin, I'll try to take a look to see if I can work out why the erode operation is not working as expected. |
This will be fixed via PR libvips/libvips#4240. Thanks for reporting this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adresses #1719.
This is mostly a copy / paste of the previous try of implementation by #1744
The
dilateoperation works well, howevererodedoes not seem to work but rather just shift the whole black pixels to the bottom right. I really can't tell why. I tried to fill the mask with 0, 128 and 255, but the results are the same.If anyone has an idea as of why it happens, I'll gladly try to fix it!