added SMTP monitor #5489
added SMTP monitor #5489
Conversation
This comment was marked as spam.
This comment was marked as spam.
server/monitor-types/smtp.js
Outdated
| /** | ||
| * @param {*} smtpSecurity the user's SMTP security setting | ||
| * @returns {boolean} True if this should test SMTPS | ||
| */ | ||
| isSMTPS(smtpSecurity) { | ||
| return smtpSecurity === "secure"; | ||
| } | ||
|
|
||
| /** | ||
| * @param {*} smtpSecurity the user's SMTP security setting | ||
| * @returns {boolean} True if this should not attempt STARTTLS, even if it is available | ||
| */ | ||
| isIgnoreTLS(smtpSecurity) { | ||
| return smtpSecurity === "nostarttls"; | ||
| } | ||
|
|
||
| /** | ||
| * @param {*} smtpSecurity the user's SMTP security setting | ||
| * @returns {boolean} True if this should always test STARTTLS | ||
| */ | ||
| isRequireTLS(smtpSecurity) { | ||
| return smtpSecurity === "starttls"; | ||
| } |
There was a problem hiding this comment.
please inline all of these. Pulling a function from this is harder to read than nessesary
| @@ -329,6 +332,15 @@ | |||
| </select> | |||
| </div> | |||
|
|
|||
| <div v-if="monitor.type === 'smtp'" class="my-3"> | |||
There was a problem hiding this comment.
please add a helptext what this monitor actually does.
People will infer that this is sending mails otherwise..
There was a problem hiding this comment.
I’ve pushed the changes based upon what I saw elsewhere in the file; let me know if they weren’t correct.
There was a problem hiding this comment.
That is not what I meant.
I meant specifying as a helptext what kind of check the selected option does.
What does Ignore STARTTLS actually check?
It does not send a mail as I would expect => please specify in the helptext that it just tries to connect.
There was a problem hiding this comment.
Got it. Thanks for clarifying.
I’ll describe them here, and also add them to the codebase:
Ignore STARTTLSsimply connects, saysHELOand looks for a correct responseUse STARTTLSconnects, saysHELO, looks forSTARTTLSin the response, issues the command, and verifies the certificateSMTPSconnects over TLS, verifies the certificate, saysHELOand looks for a correct response
Details are here. Update to the code coming shortly.
CommanderStorm
added
the
pr:please address review comments
Tick the checkbox if you understand [x]:
Description
Add SMTP monitor
This allows users to monitor SMTP/SMTPS servers. They can optionally verify STARTTLS settings, or for SMTPS, they can just verify the TLS.
Type of change
Please delete any options that are not relevant.
Checklist
Screenshots (if any)