-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add warning for cert. hostname mismatch #3942
base: master
Are you sure you want to change the base?
Feat: Add warning for cert. hostname mismatch #3942
Conversation
Have not plan to drop Node.js 14 in 2.X.X yet (Probably will be dropped in 3.X.X). Is it possible to check if X509Certificate is defined? If not defined, just always return |
Added fallback for old node.js version, added unit test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have not plan to drop Node.js 14 in 2.X.X yet
Since the plan has changed:
could you remove the parts which we don't need anymore? (otherwise looks good to go)
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Fixes #3921
Add a warning icon when the certificate info obtained does not match the monitor url, in case of unintended redirects.
This feature is only available for node.js
v15+
since it uses theX509Certificate
feature.Type of change
Checklist
(including JSDoc for methods)
Screenshots (if any)