Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add warning for cert. hostname mismatch #3942

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

chakflying
Copy link
Collaborator

@chakflying chakflying commented Oct 26, 2023

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Fixes #3921

Add a warning icon when the certificate info obtained does not match the monitor url, in case of unintended redirects.

This feature is only available for node.js v15+ since it uses the X509Certificate feature.

Type of change

  • User interface (UI)
  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

image

@louislam
Copy link
Owner

Have not plan to drop Node.js 14 in 2.X.X yet (Probably will be dropped in 3.X.X). Is it possible to check if X509Certificate is defined? If not defined, just always return true.

@chakflying
Copy link
Collaborator Author

Added fallback for old node.js version, added unit test.

@chakflying chakflying marked this pull request as ready for review October 28, 2023 08:29
@louislam louislam added this to the 2.1.0 milestone Nov 10, 2023
@chakflying chakflying added area:cert-expiry related to certificate expiry notifications area:ui/ux Interface and User Experience issues labels Jan 23, 2024
@chakflying chakflying mentioned this pull request Mar 26, 2024
7 tasks
@CommanderStorm CommanderStorm added the pr:please address review comments this PR needs a bit more work to be mergable label May 19, 2024
Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have not plan to drop Node.js 14 in 2.X.X yet

Since the plan has changed:
could you remove the parts which we don't need anymore? (otherwise looks good to go)

@github-actions github-actions bot added pr:please resolve merge conflict A merge-conflict needs to be addressed before reviewing makes sense again and removed pr:please resolve merge conflict A merge-conflict needs to be addressed before reviewing makes sense again labels May 19, 2024
@github-actions github-actions bot added pr:please resolve merge conflict A merge-conflict needs to be addressed before reviewing makes sense again and removed pr:please resolve merge conflict A merge-conflict needs to be addressed before reviewing makes sense again labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:cert-expiry related to certificate expiry notifications area:ui/ux Interface and User Experience issues needs:resolve-merge-conflict pr:please address review comments this PR needs a bit more work to be mergable pr:please resolve merge conflict A merge-conflict needs to be addressed before reviewing makes sense again
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TLS Expiry not checking intermediate redirect targets
3 participants