-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: allow slack messages to be updated #3900
base: master
Are you sure you want to change the base?
Feature: allow slack messages to be updated #3900
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Please note that some changes may be duplicate of #3394. |
I could remove the part regarding duration. It's not necessary for this functionality, but I thought it would be a nice bonus (and it takes into account the possibility of the duration being unknown, because of the limitations with heartbeats being stored for a limited time). |
What's also worth noting, is that this pull request is based on #3886, as it expands on the implemented functionality in that pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please note that some changes may be duplicate of #3394.
I could remove the part regarding duration. It's not necessary for this functionality, but I thought it would be a nice bonus
Sorry for the late review. After rereading the content, the messaging here was not clear.
=> Please remove the changes regarding the duration.
This feature should be handled at a higher level and not just in this monitor, making future work more difficult
Also note that there are a lot of changes in this PR. I don't think most are intentional => please remove those who are not
d83b897
to
bb43e6c
Compare
@CommanderStorm I've restructured the code for this pull request to be more legible. There is a lot of code, which actually is necessary, because this feature requires a different method of authenticating with slack. |
c086ac6
to
38af204
Compare
What is the status of this PR? |
Tick the checkbox if you understand [x]:
Description
Fixes #3898
Implement the Slack App way of posting messages, as well as allow for the updating of previous messages. Features a complete restructure of the way Slack messages get created
Type of change
Checklist
(including JSDoc for methods)
Screenshots (if any)