Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IP version selection #3885

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions db/knex_migrations/2023-10-14-2127-ip-family.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
exports.up = function (knex) {
// Add new column monitor.ip_family
return knex.schema
.alterTable("monitor", function (table) {
table.integer("ip_family").defaultTo(0).notNullable();
});
};

exports.down = function (knex) {
return knex.schema
.alterTable("monitor", function (table) {
table.dropColumn("ip_family");
});
};
17 changes: 14 additions & 3 deletions server/model/monitor.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ const { log, UP, DOWN, PENDING, MAINTENANCE, flipStatus, MAX_INTERVAL_SECOND, MI
SQL_DATETIME_FORMAT
} = require("../../src/util");
const { tcping, ping, checkCertificate, checkStatusCode, getTotalClientInRoom, setting, mssqlQuery, postgresQuery, mysqlQuery, setSetting, httpNtlm, radius, grpcQuery,
redisPingAsync, kafkaProducerAsync, getOidcTokenClientCredentials, rootCertificatesFingerprints, axiosAbortSignal
redisPingAsync, kafkaProducerAsync, getOidcTokenClientCredentials, rootCertificatesFingerprints, axiosAbortSignal, lookup,
} = require("../util-server");
const { R } = require("redbean-node");
const { BeanModel } = require("redbean-node/dist/bean-model");
Expand Down Expand Up @@ -111,6 +111,7 @@ class Monitor extends BeanModel {
method: this.method,
hostname: this.hostname,
port: this.port,
ipFamily: this.ipFamily,
maxretries: this.maxretries,
weight: this.weight,
active: await this.isActive(),
Expand Down Expand Up @@ -383,6 +384,16 @@ class Monitor extends BeanModel {
}

try {
let HostnameOrIp = this.hostname;
if (this.type === "ping" || this.type === "port" ) {
try {
HostnameOrIp = await lookup(this.hostname, this.ipFamily);
} catch (err) {
log.debug("monitor", `Error resolving ${this.hostname}. Error: ${err}`);
throw new Error(`Error resolving ${this.hostname}. Error: ${err}`);
}
}

if (await Monitor.isUnderMaintenance(this.id)) {
bean.msg = "Monitor under maintenance";
bean.status = MAINTENANCE;
Expand Down Expand Up @@ -620,12 +631,12 @@ class Monitor extends BeanModel {
}

} else if (this.type === "port") {
bean.ping = await tcping(this.hostname, this.port);
bean.ping = await tcping(HostnameOrIp, this.port);
bean.msg = "";
bean.status = UP;

} else if (this.type === "ping") {
bean.ping = await ping(this.hostname, this.packetSize);
bean.ping = await ping(HostnameOrIp, this.packetSize);
bean.msg = "";
bean.status = UP;
} else if (this.type === "push") { // Type: Push
Expand Down
14 changes: 11 additions & 3 deletions server/monitor-types/dns.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
const { MonitorType } = require("./monitor-type");
const { UP } = require("../../src/util");
const { UP, log } = require("../../src/util");
const dayjs = require("dayjs");
const { dnsResolve } = require("../util-server");
const { dnsResolve, lookup } = require("../util-server");
const { R } = require("redbean-node");

class DnsMonitorType extends MonitorType {
Expand All @@ -15,7 +15,15 @@ class DnsMonitorType extends MonitorType {
let startTime = dayjs().valueOf();
let dnsMessage = "";

let dnsRes = await dnsResolve(monitor.hostname, monitor.dns_resolve_server, monitor.port, monitor.dns_resolve_type);
let dnsResolveServer = monitor.dns_resolve_server;
try {
dnsResolveServer = await lookup(dnsResolveServer, monitor.ipFamily);
} catch (err) {
log.debug("monitor", `Error resolving ${monitor.dns_resolve_server}. Error: ${err}`);
throw new Error(`Error resolving ${monitor.dns_resolve_server}. Error: ${err}`);
}

let dnsRes = await dnsResolve(monitor.hostname, dnsResolveServer, monitor.port, monitor.dns_resolve_type);
heartbeat.ping = dayjs().valueOf() - startTime;

if (monitor.dns_resolve_type === "A" || monitor.dns_resolve_type === "AAAA" || monitor.dns_resolve_type === "TXT" || monitor.dns_resolve_type === "PTR") {
Expand Down
1 change: 1 addition & 0 deletions server/server.js
Original file line number Diff line number Diff line change
Expand Up @@ -782,6 +782,7 @@ let needSetup = false;
bean.port = null;
}

bean.ipFamily = monitor.ipFamily;
bean.keyword = monitor.keyword;
bean.invertKeyword = monitor.invertKeyword;
bean.ignoreTls = monitor.ignoreTls;
Expand Down
30 changes: 30 additions & 0 deletions server/util-server.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ const protojs = require("protobufjs");
const radiusClient = require("node-radius-client");
const redis = require("redis");
const oidc = require("openid-client");
const dns = require("dns");
const tls = require("tls");

const {
Expand Down Expand Up @@ -1037,6 +1038,35 @@ if (process.env.TEST_BACKEND) {
};
}

/**
* lookup the hostname and return a single IP Address of the specified IP address family.
* @param {string} hostname hostname to lookup
* @param {int} ipFamily valid values are 4 or 6 - for IPv4 or IPv6 respectively
* @returns {string} the resolved address
*/
module.exports.lookup = async (hostname, ipFamily) => {
return new Promise((resolve, reject) => {
if (ipFamily === 4 || ipFamily === 6) {
const options = {
family: ipFamily,
all: false
};
dns.lookup(hostname, options, (err, address, addrFamily) => {
log.debug("lookup", `hostname: ${hostname}, ipFamily: ${ipFamily}, address: ${address}, addrFamily: IPv${addrFamily}, err: ${err}`);
if (ipFamily !== addrFamily) {
reject("Error: Incorrect IP family.");
}
if (err) {
reject(err);
} else {
resolve(address);
}
});
} else {
resolve(hostname);
}
});

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
};

/**
* Generates an abort signal with the specified timeout.
* @param {number} timeoutMs - The timeout in milliseconds.
Expand Down
33 changes: 33 additions & 0 deletions src/pages/EditMonitor.vue
Original file line number Diff line number Diff line change
Expand Up @@ -542,6 +542,23 @@
<input id="packet-size" v-model="monitor.packetSize" type="number" class="form-control" required min="1" max="65500" step="1">
</div>

<!-- Resolve Family -->
<!-- TCP Port / Ping / DNS -->
<div v-if="monitor.type === 'port' || monitor.type === 'ping' || monitor.type === 'dns' " class="my-3">
<label for="ip-family" class="form-label">{{ $t("IP Address Family") }}</label>
<VueMultiselect
id="ip-family"
v-model="monitor.ipFamily"
:options="ipFamilyOptions.map(i => i.id)"
:custom-label="opt => ipFamilyOptions.find(e => e.id === opt).name"
:multiple="false"
:preselect-first="true"
:max-height="500"
:allow-empty="false"
:taggable="false"
></VueMultiselect>
</div>

<!-- HTTP / Keyword only -->
<template v-if="monitor.type === 'http' || monitor.type === 'keyword' || monitor.type === 'json-query' || monitor.type === 'grpc-keyword' ">
<div class="my-3">
Expand Down Expand Up @@ -1365,13 +1382,29 @@ message HealthCheckResponse {
"aws",
];

let ipFamilyOptions = [
{
id: 0,
name: "auto-detect",
},
{
id: 4,
name: "IPv4",
},
{
id: 6,
name: "IPv6",
},
];

for (let i = 100; i <= 999; i++) {
acceptedStatusCodeOptions.push(i.toString());
}

this.acceptedStatusCodeOptions = acceptedStatusCodeOptions;
this.dnsresolvetypeOptions = dnsresolvetypeOptions;
this.kafkaSaslMechanismOptions = kafkaSaslMechanismOptions;
this.ipFamilyOptions = ipFamilyOptions;
},
methods: {
/**
Expand Down
Loading