Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filter by tag value #3674

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

feat: filter by tag value #3674

wants to merge 2 commits into from

Conversation

Saimo
Copy link
Contributor

@Saimo Saimo commented Sep 1, 2023

https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

This feat allows filtering by tag values. Mostly finished on the backend but needs some cosmetic fixes.
This is an early version of the implementation.

Fixes #3641

Type of change

  • User interface (UI)
  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

image
image

@chakflying
Copy link
Collaborator

No need to commit package-lock if there are no package changes.

@CommanderStorm
Copy link
Collaborator

@Saimo Is keeping this PR a draft intentional?

Also note that this PR includes lots of (I think) unintentional changes which make reviewing difficult => please revert those.
From a UI perspective, I don't think the circles look like they fit into our current desin language => please refactor this to look more like a part of our UI to be able to merge this.

@CommanderStorm CommanderStorm added the question Further information is requested label Feb 4, 2024
@CommanderStorm CommanderStorm added pr:please address review comments this PR needs a bit more work to be mergable area:dashboard The main dashboard page where monitors' status are shown labels May 19, 2024
@github-actions github-actions bot added pr:please resolve merge conflict A merge-conflict needs to be addressed before reviewing makes sense again and removed pr:please resolve merge conflict A merge-conflict needs to be addressed before reviewing makes sense again labels May 19, 2024
@github-actions github-actions bot added pr:please resolve merge conflict A merge-conflict needs to be addressed before reviewing makes sense again and removed pr:please resolve merge conflict A merge-conflict needs to be addressed before reviewing makes sense again labels May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dashboard The main dashboard page where monitors' status are shown needs:resolve-merge-conflict pr:please address review comments this PR needs a bit more work to be mergable pr:please resolve merge conflict A merge-conflict needs to be addressed before reviewing makes sense again question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter by tag value
3 participants