Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the monitor "scheduler" from setTimeout to Croner + Queue #3447

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

louislam
Copy link
Owner

@louislam louislam commented Jul 18, 2023

Croner:

  • Supports using cron expressions for the heartbeat interval.
  • Ensures the check accuracy based on the scheduled time.

Queue:

  • Allows configuring the concurrency number.
    • A higher number means more monitors can be checked simultaneously, but it may result in increased CPU usage and higher ping.
    • A lower number may cause some monitors to be delayed, but it reduces interference from other monitors. (Potential issue: the queue could become congested)

Resolves #649
Resolves #1482
Resolves #1723
Resolves #2444
Resolves #2535
Resolves #3092
Resolves #3036
Resolves #4246

@louislam louislam added this to the 2.0.0 milestone Jul 18, 2023
@louislam louislam marked this pull request as draft July 18, 2023 19:28
@tarun7singh
Copy link
Contributor

@louislam I want to work on a bigger issue/feature do you think i can pick this up or is there any other high priority project that needs help?

@louislam louislam modified the milestones: 2.0.0, 2.1.0 Oct 16, 2023
@chakflying chakflying added the area:monitor Everything related to monitors label Dec 2, 2023
@CommanderStorm CommanderStorm added the pr:please address review comments this PR needs a bit more work to be mergable label May 19, 2024
@github-actions github-actions bot added pr:please resolve merge conflict A merge-conflict needs to be addressed before reviewing makes sense again and removed pr:please resolve merge conflict A merge-conflict needs to be addressed before reviewing makes sense again labels May 19, 2024
@github-actions github-actions bot added pr:please resolve merge conflict A merge-conflict needs to be addressed before reviewing makes sense again and removed pr:please resolve merge conflict A merge-conflict needs to be addressed before reviewing makes sense again labels May 22, 2024
@vishalsabhaya

This comment has been minimized.

@CommanderStorm

This comment has been minimized.

@d33tah
Copy link

d33tah commented Feb 7, 2025

@louislam Hi! Do you plan to continue working on this feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:monitor Everything related to monitors needs:resolve-merge-conflict pr:please address review comments this PR needs a bit more work to be mergable pr:please resolve merge conflict A merge-conflict needs to be addressed before reviewing makes sense again
Projects
None yet
6 participants