-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the monitor "scheduler" from setTimeout to Croner + Queue #3447
Draft
louislam
wants to merge
1
commit into
master
Choose a base branch
from
queue
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@louislam I want to work on a bigger issue/feature do you think i can pick this up or is there any other high priority project that needs help? |
1 task
1 task
1 task
This was referenced Dec 26, 2023
Closed
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
7 tasks
@louislam Hi! Do you plan to continue working on this feature? |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:monitor
Everything related to monitors
needs:resolve-merge-conflict
pr:please address review comments
this PR needs a bit more work to be mergable
pr:please resolve merge conflict
A merge-conflict needs to be addressed before reviewing makes sense again
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Croner:
Queue:
Resolves #649
Resolves #1482
Resolves #1723
Resolves #2444
Resolves #2535
Resolves #3092
Resolves #3036
Resolves #4246