-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add elasticsearch monitor (index
and query
)
#3322
base: master
Are you sure you want to change the base?
feat: add elasticsearch monitor (index
and query
)
#3322
Conversation
Signed-off-by: Muhammed Hussein Karimi <[email protected]>
* Add nostr DM notification provider * require crypto for node 18 compatibility * remove whitespace Co-authored-by: Frank Elsinga <[email protected]> * move closer to where it is used * simplify success or failure logic * don't clobber the non-alert msg * Update server/notification-providers/nostr.js Co-authored-by: Frank Elsinga <[email protected]> * polyfills required for node <= 18 * resolve linter warnings * missing comma --------- Co-authored-by: Frank Elsinga <[email protected]>
Signed-off-by: Muhammed Hussein Karimi <[email protected]>
Signed-off-by: Muhammed Hussein Karimi <[email protected]>
Signed-off-by: Muhammed Hussein Karimi <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as resolved.
This comment was marked as resolved.
index
and query
)index
and query
)
This comment was marked as resolved.
This comment was marked as resolved.
@CommanderStorm will do that |
I have done these steps |
Also edit is allowed by maintainers |
This comment was marked as resolved.
This comment was marked as resolved.
True. |
@CommanderStorm |
Signed-off-by: Muhammed Hussein Karimi <[email protected]>
@CommanderStorm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since then we have documented this part (how to add new monitors) in our contribution guide.
Older monitors still need to be refactored for the most part, but that should not be a merge blocker.
Okay.. what I meant by my above comment was that this PR is missing the Frontend and the backend partially.
=> please include:
- the Frontend (see contribution guide what files need to be changed)
- the Monitor (see contribution guide what files need to be changed)
- how to setup elasicsearch in the simplest way ("how to test the PR")
Please also make sure that you have filled out the Checklist from the PR-description (f.ex. the linters)
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Adding Elasticsearch monitors to index data and query data
Type of change
Please delete any options that are not relevant.
Checklist
(including JSDoc for methods)
Screenshots (if any)
Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.