Fix PostgreSQL covering index columns - #67
Merged
Conversation
Reading a table with an INCLUDE index threw InvalidCastException:
"Cannot read a non-nullable collection of elements because the returned
array contains nulls". unnest(indkey, indoption) pads the shorter array
with nulls, and indoption covers only key columns, so every included
column produced a null sort option.
Each array now unnests indkey alone and subscripts indoption by ordinal
position, and a new included_columns array feeds AddIncludedColumn so
covering indexes keep their non-key columns.
The fixture had no INCLUDE index, so nothing exercised the mismatch.
IX_Task_Covering keys on ("StatusId", "PriorityId" DESC) and includes
("Title", "Created"); the descending second key pins the indoption
subscripting as well as the included column split, so an off-by-one in
either direction fails a test rather than silently moving the sort order
onto the wrong column. Reverting the reader with the fixture in place
reproduces the original failure across every IndexTests case.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reading a table with an INCLUDE index threw InvalidCastException: "Cannot read a non-nullable collection of elements because the returned array contains nulls". unnest(indkey, indoption) pads the shorter array with nulls, and indoption covers only key columns, so every included column produced a null sort option.
Each array now unnests indkey alone and subscripts indoption by ordinal position, and a new included_columns array feeds AddIncludedColumn so covering indexes keep their non-key columns.
The fixture had no INCLUDE index, so nothing exercised the mismatch. IX_Task_Covering keys on ("StatusId", "PriorityId" DESC) and includes ("Title", "Created"); the descending second key pins the indoption subscripting as well as the included column split, so an off-by-one in either direction fails a test rather than silently moving the sort order onto the wrong column. Reverting the reader with the fixture in place reproduces the original failure across every IndexTests case.