This repository was archived by the owner on May 10, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Loren,
Are you still maintaining this repo and considering pull requests? I'm guessing the repo is old, you've moved on, and the repo is a distraction. But, OAuth1 is still in use, ObjC still in use, you have high reputation which draws people towards your source, and someone added an entry for OAuthCore to the CocaPods specs db, also drawing people here, so people are still using this repo.
Would you consider this upgrade? — ARC, Carthage & CocoaPods support (& eliminate one dependency), plus oauth_verifier param and HMAC_SHA256 digest options without disturbing original interfaces (more details below).
If you are definitely not interested, I'd really appreciate a quick 'no', then I can move on and make my fork a bit more permanent and visible.
If it's a maybe, then just let me know your feedback/issues & I'll fix. Final request if you do merge, is some tagging (talked about with podspec below).
Cheers & Bests,
Torsten
More detail on the changes:
NSData+Base64(no-ARC, and another license obligation), use-[NSData base64EncodedStringWithOptions:]from foundation instead.HMAC_SHA256digest andoauth_verifieroptions via new interface so that original interface users undisturbed. (Need for this is driven by third parties.)OAuthCoreFramework.hadded, avoiding the need to polluteOAuthCore.h. Adding Carthage/Build to .gitignore is for the case wherecarthage update --use-submoduleshas been used, and prevents the submodule git status from being dirtied when carthage adds a symlink at Carthage/Build to the actual build products folder that it uses.If you do accept the pull request please could you also tag the current master commit as 0.0.1 and tag the merged master commit as 0.0.2 (or to match whatever updated number is in the podspec).