Skip to content
This repository was archived by the owner on May 10, 2019. It is now read-only.

Conversation

@t0rst
Copy link

@t0rst t0rst commented Apr 7, 2016

Hi Loren,

Are you still maintaining this repo and considering pull requests? I'm guessing the repo is old, you've moved on, and the repo is a distraction. But, OAuth1 is still in use, ObjC still in use, you have high reputation which draws people towards your source, and someone added an entry for OAuthCore to the CocaPods specs db, also drawing people here, so people are still using this repo.

Would you consider this upgrade? — ARC, Carthage & CocoaPods support (& eliminate one dependency), plus oauth_verifier param and HMAC_SHA256 digest options without disturbing original interfaces (more details below).

If you are definitely not interested, I'd really appreciate a quick 'no', then I can move on and make my fork a bit more permanent and visible.

If it's a maybe, then just let me know your feedback/issues & I'll fix. Final request if you do merge, is some tagging (talked about with podspec below).

Cheers & Bests,
Torsten


More detail on the changes:

  • Remove dependency on NSData+Base64 (no-ARC, and another license obligation), use -[NSData base64EncodedStringWithOptions:] from foundation instead.
  • ARC. (The minimum.)
  • Add HMAC_SHA256 digest and oauth_verifier options via new interface so that original interface users undisturbed. (Need for this is driven by third parties.)
  • Carthage support. Carthage integrates frameworks, so I added a wrapper project with suitable iOS & OSX framework targets and schemes; not sure about universal framework support in carthage. Non-default framework umbrella header OAuthCoreFramework.h added, avoiding the need to pollute OAuthCore.h. Adding Carthage/Build to .gitignore is for the case where carthage update --use-submodules has been used, and prevents the submodule git status from being dirtied when carthage adds a symlink at Carthage/Build to the actual build products folder that it uses.
  • CocoaPods support. Someone added an entry for OAuthCore to the CocaPods specs db, and I am not sure whether I can update/append-to that entry, =uncertainty. However, I am certain that a local podspec will be accessible via the podfile of the host app, and hence I added one (updated for: ARC required, NSData+Base64 dependency gone, version number bumped). Happy to use different version numbering.

If you do accept the pull request please could you also tag the current master commit as 0.0.1 and tag the merged master commit as 0.0.2 (or to match whatever updated number is in the podspec).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant