-
-
Notifications
You must be signed in to change notification settings - Fork 1
Add a Summer of Making badge #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: MMK21Hub <[email protected]>
📝 WalkthroughWalkthroughA new icon and a corresponding badge entry for "Summer of Making 2025" were added to the JSON configuration file. The icon is provided as a base64-encoded PNG, and the badge includes specific label, color, message, and logo properties, integrated under the "hackclub" static badges section. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
lib/cli/kv-seed.json (1)
6-6
: Consider externalising or optimising the embedded PNG to keep the seed file slimThe new
hackclub-summer-of-making
icon is an inline PNG. At ~20 KB this single line inflates the size of the already-large seed file and makes diffs noisy.
Options:- "hackclub-summer-of-making": "data:image/png;base64, …" + // 1. Host the PNG under /public/icons and reference by URL + "hackclub-summer-of-making": "/icons/hackclub-summer-of-making.png" + + // 2. Convert to an optimised SVG (other icons are SVG) and inline that insteadEither keeps the KV seed readable and git-friendly.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
lib/cli/kv-seed.json
(2 hunks)
🔇 Additional comments (1)
lib/cli/kv-seed.json (1)
24-35
: Badge definition looks good and is consistent with existing entries
- Key name, colours, logo reference and null
links
follow the same conventions as the existing Arcade badge. No issues spotted.
We had a badge for Arcade, so now we have one for Summer of Making 2025 too :D
Here's a mockup I made by giving the same options to shields.io:
I stole the icon from https://github.com/hackclub/summer-of-making/blob/main/public/favicon.png
This change is
Summary by CodeRabbit