Add Thieves' Night On the Town -- Tnott #2824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the Town Both plugins declare entries for MarkarthNepossHouse "Nepos's House" [CELL:00016DFB] Thieves Guild Requirements adds a persistent reference. Thieves Night on the Town changes the cell's flags and locklist. Both modifications play fine together, but loading TGR after Tnott will undo Tnott's changes; loading Tnott after TGR will preserve the changes from both.
sibir-ine
requested changes
Jun 17, 2023
sibir-ine
changed the title
* C.Locklist, as MarkarthNepossHouse cell changes from being a single NPC, to a formlist of residents * C.MiscFlags, as MarkarthNepossHouse cell is not longer flagged as a public area * C.Owner, to reset ownership of MorthalThaumaturgistHouse and prevent locking issues with the new NPC * Keywords, as many Locations gained the keywords TGRWealthyHome and TGBusiness * Names, as a couple Locations had their FULL - Name record changed to match the name of the cell they contain, instead of a non-existant one.
|
The style suggestion was accepted. Five BashTags were also added. If there's additional adjustments, please advise. |
sibir-ine
requested changes
Jun 20, 2023
- Remove C.MiscFlags as its intended change should already be covered by usage of C.Owner tag - Remove extra newline at end of file
|
The suggestions are now included. I tried accepting the suggestions directly on this PR thread, but after clicking "Commit suggestion", I would get some error about the diff being updated and requiring a refresh, but no commit would have been added. So I manually committed on my local repo. |
sibir-ine
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thieves Guild Requirements and Thieves' Night on the Town
Both plugins declare entries for MarkarthNepossHouse "Nepos's House" [CELL:00016DFB]
Thieves Guild Requirements adds a persistent reference. Thieves Night on the Town changes the cell's flags and locklist.
Both modifications play fine together, but loading TGR after Tnott will undo Tnott's changes; loading Tnott after TGR will preserve the changes from both.
If submission needs style cleaning / adjustment, please advise.