Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chameleon related mod rules #616

Open
wants to merge 4 commits into
base: v0.21
Choose a base branch
from
Open

Conversation

DaCoolX
Copy link
Contributor

@DaCoolX DaCoolX commented Sep 6, 2024

No Sound Chameleon Cloak
( https://www.nexusmods.com/fallout4/mods/26648 )

overrides some entries from

Alternative Chameleon Visuals
( https://www.nexusmods.com/fallout4/mods/1886 )

if not sorted correctly and makes the screen flash effect appear again.

No Sound Chameleon Cloak
( https://www.nexusmods.com/fallout4/mods/26648 )

overrides some entries from

Alternative Chameleon Visuals
( https://www.nexusmods.com/fallout4/mods/1886 )

if not sorted correctly and makes the screen flash effect appear again.
@sibir-ine
Copy link
Member

Alternative Chameleon Visuals makes No Sound Chameleon cloak completely redundant, so it'd more appropriate to say it's already included in Alternative Chameleon Visuals:
image

@DaCoolX
Copy link
Contributor Author

DaCoolX commented Sep 7, 2024

Alternative Chameleon Visuals makes No Sound Chameleon cloak completely redundant, so it'd more appropriate to say it's already included in Alternative Chameleon Visuals: image

Noted, hope this revision is more appropriate.


- name: 'Chameleon No Sound.esp'
url:
- link: 'https://www.nexusmods.com/fallout4/mods/1886'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link is wrong, also missing a few things:

Suggested change
- link: 'https://www.nexusmods.com/fallout4/mods/1886'
- link: 'https://www.nexusmods.com/fallout4/mods/26648/'
name: 'No Sound Chameleon cloak'

url:
- link: 'https://www.nexusmods.com/fallout4/mods/1886'
msg:
- <<: *alreadyInOrFixedByX
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix is subjective:

Suggested change
- <<: *alreadyInOrFixedByX
- <<: *alreadyInX

- <<: *alreadyInOrFixedByX
subs: [ 'Alternative Chameleon Visuals' ]
condition: 'active("AltChameleonVisuals.esp") or active("NoChameleonFlash.esp")'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some extra spaces here:

Suggested change


- name: 'NoChameleonFlash.esp'
url:
- link: 'https://www.nexusmods.com/fallout4/mods/1886'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- link: 'https://www.nexusmods.com/fallout4/mods/1886'
- link: 'https://www.nexusmods.com/fallout4/mods/1886/'
name: 'Alternative Chameleon Visuals'

Comment on lines +7795 to +7797
- <<: *alreadyInX
subs: [ 'Alternative Chameleon Visuals' ]
condition: 'active("AltChameleonVisuals.esp")'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useOnlyOneX would be more appropriate here since users may have a reason to use this plugin:

Suggested change
- <<: *alreadyInX
subs: [ 'Alternative Chameleon Visuals' ]
condition: 'active("AltChameleonVisuals.esp")'
- <<: *useOnlyOneX
subs: [ 'Alternative Chameleon Visuals ESP' ]
condition: 'many("(Alt|No)Chameleon(Flash|Visuals)\.esp")'

subs: [ 'Alternative Chameleon Visuals' ]
condition: 'active("AltChameleonVisuals.esp") or active("NoChameleonFlash.esp")'

- name: 'NoChameleonFlash.esp'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To go w/ message change:

Suggested change
- name: 'NoChameleonFlash.esp'
- name: '(Alt|No)Chameleon(Flash|Visuals)\.esp'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants