-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Chameleon related mod rules #616
base: v0.21
Are you sure you want to change the base?
Conversation
No Sound Chameleon Cloak ( https://www.nexusmods.com/fallout4/mods/26648 ) overrides some entries from Alternative Chameleon Visuals ( https://www.nexusmods.com/fallout4/mods/1886 ) if not sorted correctly and makes the screen flash effect appear again.
Revise according to feedback
Unify entries
|
||
- name: 'Chameleon No Sound.esp' | ||
url: | ||
- link: 'https://www.nexusmods.com/fallout4/mods/1886' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link is wrong, also missing a few things:
- link: 'https://www.nexusmods.com/fallout4/mods/1886' | |
- link: 'https://www.nexusmods.com/fallout4/mods/26648/' | |
name: 'No Sound Chameleon cloak' |
url: | ||
- link: 'https://www.nexusmods.com/fallout4/mods/1886' | ||
msg: | ||
- <<: *alreadyInOrFixedByX |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix is subjective:
- <<: *alreadyInOrFixedByX | |
- <<: *alreadyInX |
- <<: *alreadyInOrFixedByX | ||
subs: [ 'Alternative Chameleon Visuals' ] | ||
condition: 'active("AltChameleonVisuals.esp") or active("NoChameleonFlash.esp")' | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some extra spaces here:
|
||
- name: 'NoChameleonFlash.esp' | ||
url: | ||
- link: 'https://www.nexusmods.com/fallout4/mods/1886' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- link: 'https://www.nexusmods.com/fallout4/mods/1886' | |
- link: 'https://www.nexusmods.com/fallout4/mods/1886/' | |
name: 'Alternative Chameleon Visuals' |
- <<: *alreadyInX | ||
subs: [ 'Alternative Chameleon Visuals' ] | ||
condition: 'active("AltChameleonVisuals.esp")' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
useOnlyOneX
would be more appropriate here since users may have a reason to use this plugin:
- <<: *alreadyInX | |
subs: [ 'Alternative Chameleon Visuals' ] | |
condition: 'active("AltChameleonVisuals.esp")' | |
- <<: *useOnlyOneX | |
subs: [ 'Alternative Chameleon Visuals ESP' ] | |
condition: 'many("(Alt|No)Chameleon(Flash|Visuals)\.esp")' |
subs: [ 'Alternative Chameleon Visuals' ] | ||
condition: 'active("AltChameleonVisuals.esp") or active("NoChameleonFlash.esp")' | ||
|
||
- name: 'NoChameleonFlash.esp' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To go w/ message change:
- name: 'NoChameleonFlash.esp' | |
- name: '(Alt|No)Chameleon(Flash|Visuals)\.esp' |
No Sound Chameleon Cloak
( https://www.nexusmods.com/fallout4/mods/26648 )
overrides some entries from
Alternative Chameleon Visuals
( https://www.nexusmods.com/fallout4/mods/1886 )
if not sorted correctly and makes the screen flash effect appear again.