encoder: match buffer length when capacity grows #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Buffer` data structure has an internal byte slice that is expanded when the `Grow()` method is called. Since the effective buffer length is tracked using the `offset` variable, the underlying slice length must also be expanded to match its new capacity, otherwise accessing `b.b[b.offset]` may result in an `index out of range` runtime panic. Signed-off-by: Luiz Aoqui <[email protected]>
lgfa29
force-pushed
the
fix-enconding-index-error
branch
from
ca56c08 to
8300c51
Compare
|
CI error is unrelated and fixed in #162 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Bufferdata structure has an internal byte slice that is expanded when theGrow()method is called. Since the effective buffer length is tracked using theoffsetvariable, the underlying slice length must also be expanded to match its new capacity, otherwise accessingb.b[b.offset]may result in anindex out of rangeruntime panic.