Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add user references and logo for PTG #864

Merged
merged 1 commit into from
Aug 6, 2019
Merged

add user references and logo for PTG #864

merged 1 commit into from
Aug 6, 2019

Conversation

agnes512
Copy link
Contributor

@agnes512 agnes512 commented Aug 6, 2019 •
edited
Loading

@agnes512 agnes512 requested a review from bschrammIBM as a code owner August 6, 2019 15:41
dhmlau
dhmlau reviewed Aug 6, 2019
View reviewed changes
@agnes512
Copy link
Contributor Author

agnes512 commented Aug 6, 2019

After adding the logo:
Screen Shot 2019-08-06 at 11 43 48 AM

After adding the testimony:
Screen Shot 2019-08-06 at 11 45 23 AM

dhmlau
dhmlau reviewed Aug 6, 2019
View reviewed changes
Copy link
Member

@dhmlau dhmlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agnes512, thanks for updating this. If you have a screen cap of what's that section is gonna look like, that would be easier to review. Thanks.

dhmlau
dhmlau approved these changes Aug 6, 2019
View reviewed changes
Copy link
Member

@dhmlau dhmlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please squash the commits before merging. Thanks.

@agnes512 agnes512 force-pushed the user-reference-ptg branch from b3a82fd to 18f2932 Compare August 6, 2019 16:14
@agnes512 agnes512 merged commit 26ea9d7 into gh-pages Aug 6, 2019
@delete-merged-branch delete-merged-branch bot deleted the user-reference-ptg branch August 6, 2019 16:32
HaroldV pushed a commit to HaroldV/loopback.io that referenced this pull request Oct 7, 2019
@agnes512 @HaroldV
add user references for ptg (loopbackio#864)
b4e4de4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhmlau dhmlau dhmlau approved these changes

@bschrammIBM bschrammIBM Awaiting requested review from bschrammIBM

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agnes512 @dhmlau