Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(cli): use snapshots to match list of commands in help #3786

Merged
merged 1 commit into from
Sep 23, 2019
Merged

test(cli): use snapshots to match list of commands in help #3786

merged 1 commit into from
Sep 23, 2019

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented Sep 23, 2019 •
edited
Loading

I discovered this opportunity while working on #3688 where I am adding a new CLI command.

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@bajtos bajtos requested review from raymondfeng and a team September 23, 2019 07:16
@bajtos bajtos self-assigned this Sep 23, 2019
hacksparrow
hacksparrow approved these changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@hacksparrow hacksparrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻

@bajtos bajtos merged commit a6863e5 into master Sep 23, 2019
@bajtos bajtos deleted the test/cli-help branch September 23, 2019 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hacksparrow hacksparrow hacksparrow approved these changes

@raymondfeng raymondfeng Awaiting requested review from raymondfeng

Assignees

@bajtos bajtos

Labels
CLI refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bajtos @hacksparrow