Recommended bolus for Trio #466
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
codebymini
approved these changes
Oct 4, 2025
| @State private var statusMessage: String? = nil | ||
|
|
||
| private let pushNotificationManager = PushNotificationManager() | ||
| private let minDeliverableU: Double = 0.05 // hides negative/zero/tiny recs |
There was a problem hiding this comment.
Could be renamed to minDeliverableUnit for improved readability
|
It does not really make sense to display a bolus value that the pump cannot administer (0.96 U in your example for what I presume is a pod user on Trio). The overall bolus seems to have 3 decimals; bolus dosages are usually rounded up to 2 decimals in allowed increments. Where is this recommended value coming from on the Trio side? |
|
LoopFollow currently does not know what pump is used, and therefore not what increments used. I plan to introduce a setting for it. I believe it can be fetched from Loop. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trio Remote Control: Recommended Bolus on Bolus Screen
This PR adds a flow for using the Recommended Bolus in the Trio Remote Control bolus view.
What’s included
Why
Make it quick to use a safe, recent recommendation—and avoid nudging users toward stale or invalid values.