Clear override text conditionally based on device #423
+6
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves issue #403.
Description:
This change introduces a conditional clearing of the override information in the
infoManager
. Previously, the override data was cleared every time the device status was updated.This caused an issue for Trio users, where the override text would disappear from the display. This happened because for Trio, override information is fetched from treatments, and the device status does not contain this data. If a device status update occurred after the treatment data was processed, the override information would be incorrectly cleared.
For "Loop" devices, the override information is part of the device status, so clearing it upon refresh is the correct behavior to ensure the display is up-to-date.
Changes:
updateDeviceStatusDisplay(jsonDeviceStatus:)
, the call toinfoManager.clearInfoData(types: [.override])
is now wrapped in a conditional check.This ensures that the override information is handled correctly for both Loop and Trio users, fixing the glitch where the override text would intermittently disappear for the latter.