Skip to content

feat: Add filteredQuery to tile host data #1329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

feat: Add filteredQuery to tile host data #1329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fcae888
Add filteredQuery to tile host data
rdunlavy-google Jun 20, 2023
317abc0
empty commit
rdunlavy-google Jun 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions packages/extension-sdk/src/connect/tile/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
*/

import type { MouseEvent } from 'react'
import type { IQuery } from '@looker/sdk'

/**
* Callback that is invoked when a change in the host happens
Expand Down Expand Up @@ -69,7 +70,7 @@ export interface TileHostData {
* cross filtering applied to the dashboard. Filters and cross filters
* will need to be applied and a new query generated in order to reflect
* the data shown in the QueryResponse. As such the queryId may not be
* that useful.
* that useful. See filteredQuery for query object with filters applied.
*/
queryId?: string
/**
Expand All @@ -82,7 +83,7 @@ export interface TileHostData {
* cross filtering applied to the dashboard. Filters and cross filters
* will need to be applied and a new query generated in order to reflect
* the data shown in the QueryResponse. As such the queryId may not be
* that useful.
* that useful. See filteredQuery for query object with filters applied.
*/
querySlug?: string
/**
Expand Down Expand Up @@ -112,6 +113,12 @@ export interface TileHostData {
* is being configured as an explore this will not be populated.
*/
isDashboardCrossFilteringEnabled?: boolean
/**
* A query object that matches the query ID associated with the
* underlying dashboard element with any dashboard filters and
* timezone changes made at the dashboard level applied.
*/
filteredQuery?: IQuery
/**
* The id of the tile extension element that triggered the last
* dashboard run. The id will be undefined if the dashboard run
Expand Down
6 changes: 6 additions & 0 deletions ...tension-tile-playground/src/components/Inspector/components/TileHostData/TileHostData.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ export const TileHostData: React.FC = () => {
lastRunEndTime,
lastRunSuccess,
lastRunSourceElementId,
filteredQuery,
} = tileHostData

const dashboardIdMessage = `Dashboard id is "${
Expand Down Expand Up @@ -101,6 +102,10 @@ export const TileHostData: React.FC = () => {
.map(([key, value]) => `${key}=${value}`)
.join(', ')

const filteredQueryMessage = filteredQuery
? `Filtered query: ${JSON.stringify(filteredQuery, null, 1)}`
: 'No filtered query available.'

return (
<Card>
<CardContent>
Expand All @@ -121,6 +126,7 @@ export const TileHostData: React.FC = () => {
? `Dashboard filters are ${filtersArray}`
: 'Dashboard has no filters'}
</Paragraph>
<Paragraph>{filteredQueryMessage}</Paragraph>
</>
)}
</SpaceVertical>
Expand Down