This repository was archived by the owner on Jun 8, 2024. It is now read-only.
Fixed deadlock in caller's Task.WhenAll#108
Open
ogonzalez-sd wants to merge 3 commits intolontivero:masterfrom
Open
Fixed deadlock in caller's Task.WhenAll#108ogonzalez-sd wants to merge 3 commits intolontivero:masterfrom
ogonzalez-sd wants to merge 3 commits intolontivero:masterfrom
Conversation
When Task.Factory.StartNew is called with an already cancelled token, the resulting task never reaches completed.
lontivero
suggested changes
Jan 7, 2022
Owner
lontivero
left a comment
lontivero
left a comment
There was a problem hiding this comment.
Good catch. Please address my comments and remember to use Tabs for this project. Also, please add yourself as a contributor here: https://github.com/lontivero/Open.NAT/blob/master/AUTHORS
Also switched to tabs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Task.Factory.StartNew is called with an already cancelled token, the resulting task never reaches completed.