This repository was archived by the owner on Jun 8, 2024. It is now read-only.
Catch exceptions from UdpClient.Recieve#107
Open
ogonzalez-sd wants to merge 3 commits intolontivero:masterfrom
Open
Catch exceptions from UdpClient.Recieve#107ogonzalez-sd wants to merge 3 commits intolontivero:masterfrom
ogonzalez-sd wants to merge 3 commits intolontivero:masterfrom
Conversation
Common occurrance: SocketException: Connection was closed by remote host
lontivero
suggested changes
Jan 7, 2022
Owner
lontivero
left a comment
lontivero
left a comment
There was a problem hiding this comment.
Thanks for the contribution. Please address the comments in my feedback.
Moved try/catch to Search's while loop Used tabs, not spaces Removed unnecessary line
Author
|
I moved the try/catch block, but I still think exceptions should be caught inside Receive's loop so that we can continue to read from other sockets if any should fail, but I defer to your expertise |
Author
|
@lontivero Let me know these follow up changes are satisfactory |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Common occurrance: SocketException: Connection was closed by remote host