This repository was archived by the owner on Jun 8, 2024. It is now read-only.
Filter illegal hexadecimal characters that can be returned from an unnp device.#105
Open
DennisCorvers wants to merge 2 commits intolontivero:masterfrom
Open
Filter illegal hexadecimal characters that can be returned from an unnp device.#105DennisCorvers wants to merge 2 commits intolontivero:masterfrom
DennisCorvers wants to merge 2 commits intolontivero:masterfrom
Conversation
Owner
|
Thanks for the PR. I don't understand what the logger was added for and the |
Author
|
The logger was added to have some additional information when a debugger is not available. And the try-catch block is right. It returns an empty XmlDocument instead of causing an application crash. The empty document is handled in a different part without causing a crash. The \x00 occurred at the very start of the message in this case, where a specific device returned an extra header line with non-xml formatted information. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.