Monitoring-only mode changes + new environment for PIO #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twilighlord-owie-esp8266 board added to platformio.ini
Monitoring-only mode
lolwheel
reviewed
Aug 12, 2022
| @@ -51,3 +51,34 @@ upload_protocol = custom | |||
| [env:native] | |||
| platform = native | |||
| debug_test = test_bms_relay | |||
|
|
|||
| @@ -59,39 +65,46 @@ <h2>Owie Settings</h2> | |||
| form.setAttribute("action", oldAction); | |||
| }; | |||
|
|
|||
| const monCheckbox = document.getElementById("monChk"); | |||
There was a problem hiding this comment.
This bit won't be necessary if instead of using the dataset on the checkbox you directly dump the checked attribute on it.
i.e. "<input type="checkbox" %SPOOFING_DISABLED%>" and SPOOFING_DISABLED is either "" or "checked"
| @@ -12,5 +12,6 @@ message SettingsMsg { | |||
| int32 wifi_power = 8; | |||
| bool is_locked = 9; // if the board is actively locked/parked | |||
| bool locking_enabled = 10; // if the board locking functionality is enabled ('armed') | |||
| reserved 11; | |||
| bool monitoring_only_enabled = 11; | |||
| reserved 12; | |||
There was a problem hiding this comment.
Reserved IDs are for the fields that have been removed. These IDs shouldn't be reused, that's why it's called reserved. I'd also call the boolean monitoring_only_mode.
So this should be:
bool monitoring_only_mode = 12;
reserved 11;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.