Fix construction of stand-alone public keys #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PublicKey "from" implementations didn't reverse the "encode" operation from PublicKey::as_byte, and so a stand-alone PublicKey could not be correctly constructed from bytes. (PublicKeys constructed from PrivateKeys were fine.) With this change the RFC8032 test-vectors in rfc8032.rs all pass even when verifying the signatures using a PublicKey constructed from bytes. A couple of unit-tests needed updating as not all 57-byte octet sequences are valid Ed448 public keys (which is correct).
|
I would love to see this PR to get merged into master and released as a new version since I really need the public key construction. @pdh11 thanks for this PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PublicKey "from" implementations didn't reverse the "encode"
operation from PublicKey::as_byte, and so a stand-alone PublicKey could
not be correctly constructed from bytes. (PublicKeys constructed from
PrivateKeys were fine.)
With this change the RFC8032 test-vectors in rfc8032.rs all pass even
when verifying the signatures using a PublicKey constructed from bytes.
A couple of unit-tests needed updating as not all 57-byte octet
sequences are valid Ed448 public keys (which is correct).
With this change an (unpublished) rust TLS client library can now successfully
connect to a GnuTLS server using ed448-rust signatures for certificates and ECDHE
parameters.