Open
Conversation
Ivansete-status
requested review from
NagyZoltanPeter,
darshankabariya and
igor-sirotin
|
You can find the image built from this PR at Built from d64e9a9 |
fcecin
reviewed
Mar 2, 2026
| ctx: ptr FFIContext[Waku], | ||
| callback: FFICallBack, | ||
| userData: pointer, | ||
| nodeInfoId: cstring, |
Contributor
There was a problem hiding this comment.
Is this 4th argument right? Looks like logosdelivery_get_available_configs is declared with 3 args?
int logosdelivery_get_available_configs(void *ctx,
FFICallBack callback,
void *userData);
Collaborator
Author
There was a problem hiding this comment.
Wow great catch! Thanks ! 🙌
Addressed in a0b6029
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This introduces changes to implement the specs that have been added in this.
Changes
int logosdelivery_get_available_node_info_idsint logosdelivery_get_node_infoint logosdelivery_get_available_configsliblogosdelivery/examples/logosdelivery_example.cto use the new functions.Related Issue