Open
Conversation
richard-ramos
approved these changes
Jan 30, 2026
Fixes issues with windows builds: vacp2p/nim-lsquic@4fb03ee7 And updates lsquic submodule URL: vacp2p/nim-lsquic@37fb01e2 Signed-off-by: Jakub Sokołowski <jakub@status.im>
6d7886c to
5874a1c
Compare
Ivansete-status
approved these changes
Jan 30, 2026
|
You can find the image built from this PR at Built from bddcda9 |
Contributor
Author
|
This doesn't look good: |
Collaborator
|
@jakubgs - I'll take a look at the issue |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes issues with windows builds:
And updates lsquic submodule URL:
Issue